Page MenuHomePhabricator

SMW 1.6.2 #ask 'format' parameter is case-sensitive now!
Closed, ResolvedPublic

Description

Another, rather serious bug introduced in SMW 1.6.2:
{{#show: [[Name::+]]

?Name
format = List

}}
This will print in table format because the format parameter seems to be case-sensitive now.
{{#show: [[Name::+]]

?Name
Format = list

}}
works fine. Some other parameter values I tested still were case-insensitive.
This broke quite some templates in my Wiki. Also there are many format examples out there, where the format name is given in uppercase!

Perhaps the Validator extension should get some optional case-insensitive setting for validating string parameters.


Version: unspecified
Severity: normal

Details

Reference
bz31138

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:51 PM
bzimport set Reference to bz31138.
bzimport added a subscriber: Unknown Object (MLST).
Danwe created this task.Sep 24 2011, 4:39 PM

When are you seeing this? I cannot reproduce this, and the code looks valid. Can you link to where you are seeing such behavior?

This is 1.6.2 right? Not some random alpha version?

Danwe added a comment.Sep 24 2011, 6:02 PM

Yes, I am positive. I just reset one of my local wikis to the original 1.6.2 release to make sure.
Sorry, can't give you a link since I only have local wikis running on 1.6.2 till everything works fine.

In the SMWW sandbox wiki it works, BUT apparently there is still the 1.6.2 alpha running, not the final release.

Well, it's fixed on trunk. I actually pulled 1.6.2 as ask was broken due to an issue in the format defaulting and recommend not using it for now. I'll try release a 1.6.2.1 soonish to address that. Sorry for the hassle and thanks for reporting this :)

Danwe added a comment.Jan 4 2012, 10:58 PM

This bug seems to be back in 1.7 and current trunk!

How did this get back into 1.7? Would be even worth a fast 1.7.1 release since it is potentially breaking wikis again.

Danwe added a comment.Jan 4 2012, 11:02 PM

Solved in r108095.

Thanks for fixing this. I don't think it's that critical to force a quick release though - the fact that no one complained about this while it has been on trunk for months (and many people run trunk or tried the beta/rc) suggests that very few people actually do not use non-lower cased names.