Page MenuHomePhabricator

DiscussionTools is adding a class to h2 elements and that breaks custom css
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue and what happens:

What should have happened instead?:

  • Display:block prevents custom css on headers, and I don't think this is supposed to happen.

Other information (browser name/version, screenshots, etc.):
I tested with every skin available and the issue appears in all of them. Changing h2 to div solved it.

Event Timeline

What is "column 5"?

The fifth character? Sorry, it's the way my notebook counts mouse position within text

It looks like the problem isn't the class, it's the wrapper element <div class="mw-heading mw-heading2 ext-discussiontools-init-section"> being added around your <h2 class="time-slot" ...>.

To avoid problems, I'd just add another wrapper around all of these, like so:

<div class="time-slot" style="grid-row: time-{{{horas_inicio}}}{{{minutos_inicio}}}"><h3>{{{horas_inicio}}}{{#ifeq:{{{dia|}}}|24|&#42889;|&#58;}}{{{minutos_inicio}}}</h3></div>

Will that work?

matmarex claimed this task.

Since T353489, the wrappers won't be added around <h2> and other heading tags that have any attributes, which actually fixes the original issue in this task as well. You can change the div to h2 now if you wish.