Resolve diferences between Parsoid & legacy parser TOC metadata output for template, extension, and parser-function generated content
Open, HighPublic
Actions

Assigned To

None

Authored By

	ssastry
	Mar 7 2023, 9:15 PM

Description

See the tests/parser/toc.txt file in Parsoid which specs out TOC metadata for wikitext.

As the file documents in comments for various tests, when the content comes from templates (or parser functions or extensions), Parsoid's output and legacy parser output differ. We should reconcile these differences depending on expectations for this metadata by other products / code.

Details

Subject	Repo	Branch	Lines +/-
Bump wikimedia/parsoid to 0.19.0-a23	mediawiki/vendor	master	+209 -79
Strip entity spans from toc lines	mediawiki/services/parsoid	master	+5 -6
Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0	mediawiki/vendor	master	+357 -205
TOCData Computation: Eliminate some egregious diffs with legacy parser	mediawiki/services/parsoid	master	+13 -21

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
Open		None	T272987 [EPIC] Parsoid read views for DiscussionTools
Resolved		cscott	T269630 Parsoid should support section editing links
Open		None	T331483 Resolve diferences between Parsoid & legacy parser TOC metadata output for template, extension, and parser-function generated content
Resolved		cscott	T213468 Parsoid section IDs don't correspond to PHP section IDs when headings are transcluded
Open		None	T215628 Make Parsoid and PHP edit-section numbering consistent when <noinclude> and <includeonly> are in use
Open		None	T214538 MediaWiki shouldn't assign section ids during tokenization, but instead only when headings are generated
Open		None	T359221 Parsoid's TOC handling needs to deal with HTML-returning components (exts, SPTs, parser funcs returning HTML) consistently
Resolved		ssastry	T359450 Parsoid is not adding headings to TOC entries in some templated content scenarios

Event Timeline

ssastry created this task.Mar 7 2023, 9:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2023, 9:15 PM

Extension and parser function related output probably doesn't matter, but template-generated content generates section edit links directly to the appropriate section of the transcluded page, and it's important to get that right. In the worst case, a differing section index could cause corruption during save (the wrong section replaced) although the more likely error is that clicking on the section edit link will start editing the "wrong" section.

Finally, see https://gerrit.wikimedia.org/r/c/wikipeg/+/508037 and the related T222419#5216719.

cscott added a parent task: T269630: Parsoid should support section editing links.Mar 8 2023, 6:23 PM

cscott added subtasks: T213468: Parsoid section IDs don't correspond to PHP section IDs when headings are transcluded, T215628: Make Parsoid and PHP edit-section numbering consistent when <noinclude> and <includeonly> are in use, T214538: MediaWiki shouldn't assign section ids during tokenization, but instead only when headings are generated.

cscott moved this task from Needs Triage to Missing Functionality on the Parsoid board.Mar 9 2023, 3:28 PM

Change 896369 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] TOCData computation: Eliminate some egregious diffs with legacy parser

https://gerrit.wikimedia.org/r/896369

gerritbot added a project: Patch-For-Review.Mar 10 2023, 3:19 PM

Change 896369 merged by jenkins-bot:

[mediawiki/services/parsoid@master] TOCData Computation: Eliminate some egregious diffs with legacy parser

https://gerrit.wikimedia.org/r/896369

Maintenance_bot removed a project: Patch-For-Review.Mar 10 2023, 5:10 PM