Page MenuHomePhabricator

Change `assert` to `expect` in WikiLambda browser tests
Closed, ResolvedPublic

Description

In /tests/selenium/specs directory nodejs inbuilt assert module is being used. The project already uses webdriverio that comes with its own assertion library called expect-webdriverio that provides more complex assertions methods as well as are more readable. The task is to change assert to expect. Even the jest directory uses expect.

See T380409: Ensure quickstart provisions a working wikilambda.

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedFeaturekostajh
OpenNone
OpenNone
OpenNone
DeclinedNone
ResolvedNone
ResolvedNone
Resolvedawight
Resolvedkostajh
OpenNone
Resolvedcscott
Resolvedkostajh
Resolvedkostajh
Resolvedkostajh
Resolvedhashar
OpenNone
ResolvedPRODUCTION ERRORhoo
ResolvedLucas_Werkmeister_WMDE
ResolvedNone
ResolvedDreamy_Jazz
ResolvedKrinkle
Resolvedhashar
ResolvedNone
OpenNone
OpenNone
OpenNone
ResolvedNik.xyz.in
OpenNone

Event Timeline

Change 894584 had a related patch set uploaded (by Nik.xyz.in; author: Nik.xyz.in):

[mediawiki/extensions/WikiLambda@master] selenium-test: change assert to expect

https://gerrit.wikimedia.org/r/894584

Jdforrester-WMF renamed this task from Change `assert` to `expect` to Change `assert` to `expect` in WikiLambda browser tests.Mar 8 2023, 2:31 PM

Change 894584 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] selenium-test: change assert to expect

https://gerrit.wikimedia.org/r/894584

zeljkofilipin subscribed.

Reopening since there are still tests left that use assert (code search).

Change #1135095 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] selenium tests: Fix one last use of assert

https://gerrit.wikimedia.org/r/1135095

Change #1135095 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] selenium tests: Fix one last use of assert

https://gerrit.wikimedia.org/r/1135095

As far as I can see, this is resolved. Please reopen if there's something left to do.