Page MenuHomePhabricator
Create Task
Maniphest T331486

Visual Editor produces garbage with HTML entities inside templates
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

A small example to reproduce the same issue is at https://en.wikipedia.org/w/index.php?title=User:RoySmith/sandbox&oldid=1143459733

Also see discussion at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Newlines_in_templates%3F

Chrome Version 110.0.5481.177 (Official Build) (x86_64)
MacOS Monterey

Details

SubjectRepoBranchLines +/-
Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0mediawiki/vendormaster+357 -205
TableFixups: Use entity wt, not rendered text, while fixing cellsmediawiki/services/parsoidmaster+21 -1
Customize query in gerrit

Related Objects

Event Timeline

RoySmith created this task.Mar 7 2023, 9:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2023, 9:47 PM
RoySmith mentioned this in T331487: Visual Editor produces garbage with HTML entities inside templates.Mar 7 2023, 9:53 PM
Esanders added a project: Parsoid.Mar 7 2023, 10:10 PM
Esanders updated the task description. (Show Details)
ssastry claimed this task.Mar 7 2023, 10:20 PM
ssastry added projects: Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support).
ssastry subscribed.

This is probably an edge-case bug in the TableFixups code in Parsoid.

gerritbot added a comment.Mar 7 2023, 10:55 PM

Change 895367 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] TableFixups: Use entity wt, not rendered text, while fixing cells

https://gerrit.wikimedia.org/r/895367

gerritbot added a project: Patch-For-Review.Mar 7 2023, 10:55 PM
ssastry triaged this task as Medium priority.Mar 7 2023, 10:55 PM
ssastry moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
ssastry moved this task from Backlog to Code Review on the Parsoid-Read-Views (Phase 2 - testwiki Main namespace support) board.
ssastry moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.
Pppery merged a task: T331487: Visual Editor produces garbage with HTML entities inside templates.Mar 7 2023, 11:11 PM
gerritbot added a comment.Mar 9 2023, 1:26 AM

Change 895367 merged by jenkins-bot:

[mediawiki/services/parsoid@master] TableFixups: Use entity wt, not rendered text, while fixing cells

https://gerrit.wikimedia.org/r/895367

Maintenance_bot removed a project: Patch-For-Review.Mar 9 2023, 1:30 AM
ppelberg added a project: Editing-team (Tracking).Mar 9 2023, 4:45 PM
ppelberg moved this task from Backlog to External on the Editing-team (Tracking) board.
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.
gerritbot added a comment.Mar 10 2023, 6:23 PM

Change 896413 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0

https://gerrit.wikimedia.org/r/896413

gerritbot added a project: Patch-For-Review.Mar 10 2023, 6:23 PM
gerritbot added a comment.Mar 10 2023, 6:56 PM

Change 896413 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0

https://gerrit.wikimedia.org/r/896413

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 10 2023, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 10 2023, 7:11 PM
• JMcLeod_WMF moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Mar 13 2023, 3:06 PM
ssastry moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Mar 16 2023, 1:00 AM
ssastry closed this task as Resolved.Mar 17 2023, 2:49 AM

https://en.wikipedia.org/api/rest_v1/page/html/User:SSastry_(WMF)%2FSandbox/1144869788 looks right now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits