Page MenuHomePhabricator

Ping and notification icons changed from gray to black in skin Vector 2010
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Color is black

image.png (68×202 px, 1 KB)

What should have happened instead?:

  • Color should be gray

image.png (87×179 px, 1 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Black looks fine on Vector 2022, but should be gray on Vector. Perhaps some kind of change for Vector 2022 had collateral damage to Vector.
  • Fine in wmf.25, bug in wmf.26

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh claimed this task.
kostajh subscribed.

It is a deliberate change ("The decided fix is to never use 50% opacity as that looks like a disabled button, which they aren't."), so I am closing this and whoever is interested can continue discussion in T329300.

Frostly changed the task status from Resolved to Invalid.Mar 10 2023, 12:32 AM

Reopening per T329300#8681686. Sounds like this wasn't intentional.

Change 902153 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/Echo@master] Revert "Remove 50% opacity from notification badges when they are all read"

https://gerrit.wikimedia.org/r/902153

Change 902154 had a related patch set uploaded (by Samtar; author: Novem Linguae):

[mediawiki/extensions/Echo@wmf/1.40.0-wmf.27] Revert "Remove 50% opacity from notification badges when they are all read"

https://gerrit.wikimedia.org/r/902154

Change 902155 had a related patch set uploaded (by Samtar; author: Novem Linguae):

[mediawiki/extensions/Echo@wmf/1.41.0-wmf.1] Revert "Remove 50% opacity from notification badges when they are all read"

https://gerrit.wikimedia.org/r/902155

Change 902153 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Revert "Remove 50% opacity from notification badges when they are all read"

https://gerrit.wikimedia.org/r/902153

Change 902155 abandoned by Samtar:

[mediawiki/extensions/Echo@wmf/1.41.0-wmf.1] Revert "Remove 50% opacity from notification badges when they are all read"

Reason:

Wasn't needed

https://gerrit.wikimedia.org/r/902155

Change 902154 abandoned by Samtar:

[mediawiki/extensions/Echo@wmf/1.40.0-wmf.27] Revert "Remove 50% opacity from notification badges when they are all read"

Reason:

Wasn't needed

https://gerrit.wikimedia.org/r/902154

Novem_Linguae claimed this task.

Change 902154 restored by Esanders:

[mediawiki/extensions/Echo@wmf/1.40.0-wmf.27] Revert "Remove 50% opacity from notification badges when they are all read"

https://gerrit.wikimedia.org/r/902154

Change 902154 abandoned by Esanders:

[mediawiki/extensions/Echo@wmf/1.40.0-wmf.27] Revert "Remove 50% opacity from notification badges when they are all read"

Reason:

wrong patch

https://gerrit.wikimedia.org/r/902154