Page MenuHomePhabricator

Inline Switch: VE should activate/deactivate inline format toggle
Closed, ResolvedPublic5 Estimated Story Points

Description

Visual Editor should be able to enable/disable the 'inline` toggle when user toggles between Visual and Wikitext formats.

Feature Summary

On the current experience, a user is able to use different diff formats:

  • Visual when VE is installed (URL param diffmode=visual)

The VE extension should disabled Inline toggle when Visual is selected. The extension should include functionality that allows others to determine what needs to be shown when Wikitext is selected.

Use Cases

As a viewer, I am able to switch between different diff formats.

The diff format options display the options according to installation.

Fresh install with VE enabled and without Wikidiff2 the toggle options should be:
"Visual", Wikitext"

Fresh install with VE enabled and with Wikidiff2 enabled the toggle options should:

  • "Visual", "Wikitext", "Inline"
  • The inline toggle should be active when wikitext option is selected.
  • The inline toggle should be deactived when Visual option is selected.

Designs

  • Wikitext is selected

Screenshot from 2023-04-28 13-58-23.png (234Γ—537 px, 51 KB)

  • Visual is selected

Screenshot from 2023-04-28 13-58-55.png (219Γ—464 px, 41 KB)

Event Timeline

HMonroy renamed this task from Add VE diff format options to dropdown to VE should add the visual diff format option to dropdown.Mar 9 2023, 6:07 AM
HMonroy updated the task description. (Show Details)
HMonroy updated the task description. (Show Details)
HMonroy updated the task description. (Show Details)
HMonroy renamed this task from VE should add the visual diff format option to dropdown to Dropdown: VE should add the visual diff format option to dropdown.Mar 16 2023, 4:59 AM
HMonroy renamed this task from Dropdown: VE should add the visual diff format option to dropdown to Dropdown: VE should add the `Visual` diff format option to dropdown.
HMonroy updated the task description. (Show Details)
HMonroy updated the task description. (Show Details)
HMonroy set the point value for this task to 5.Mar 22 2023, 7:11 PM

Change 902540 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/extensions/VisualEditor@master] Better Diffs: Add 'Visual' diff format option to diff dropdown

https://gerrit.wikimedia.org/r/902540

Change 902540 abandoned by HMonroy:

[mediawiki/extensions/VisualEditor@master] Diff: Add 'Visual' diff format option to diff dropdown

Reason:

Requirements have changed for switching between different "diff" formats

https://gerrit.wikimedia.org/r/902540

HMonroy renamed this task from Dropdown: VE should add the `Visual` diff format option to dropdown to Switch: VE should handle switch toggle when inline format is available.Apr 28 2023, 8:25 PM
HMonroy updated the task description. (Show Details)
HMonroy renamed this task from Switch: VE should handle switch toggle when inline format is available to Switch: VE should handle inline format toggle .May 1 2023, 9:38 PM
HMonroy updated the task description. (Show Details)
HMonroy updated the task description. (Show Details)
HMonroy updated the task description. (Show Details)
HMonroy renamed this task from Switch: VE should handle inline format toggle to Switch: VE should activate/deactivate inline format toggle .May 1 2023, 11:03 PM
HMonroy updated the task description. (Show Details)
HMonroy renamed this task from Switch: VE should activate/deactivate inline format toggle to Inline Switch: VE should activate/deactivate inline format toggle .May 2 2023, 5:14 AM

Change 914173 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/extensions/VisualEditor@master] Inline Switch: Inline toggle should be active with "source" mode

https://gerrit.wikimedia.org/r/914173

Test wiki created on Patch demo by HMonroy (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/5a14d7cd9f/w

Change 914173 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] React to hooks that are fired when inline switch is present

https://gerrit.wikimedia.org/r/914173

@HMonroy No issues with VE should activate/deactivate inline format toggle. The only issues I came across were from https://phabricator.wikimedia.org/T336716#8966088. Since they are covered on that, I will move this ticket to Done. Thanks!

Environment: Local
Skins: Vector 2022, 2010, Monobook, Minerva, Timeless
Browsers: Chrome 114, Firefox 114, Safari 16.5
OS: macOS 13.4
Test link: http://localhost:8080/w/index.php?title=Atlantic_Ocean&diff=556&oldid=555