Page MenuHomePhabricator

Rename $wgPageTriageEnableEnglishWikipediaFeatures to $wgPageTriageEnableExtendedFeatures
Closed, ResolvedPublic

Description

Requested by @Stang in T323378

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 960161 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Rename the $wgPageTriageEnableEnglishWikipediaFeatures variable

https://gerrit.wikimedia.org/r/960161

Test wiki created on Patch demo by MPGuy2824 using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/32e9cb7926/w

MPGuy2824 changed the task status from Open to In Progress.Sep 23 2023, 8:13 AM
MPGuy2824 claimed this task.
MPGuy2824 moved this task from Priority wiki agnostic to Code Review on the PageTriage board.

Change 965395 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[operations/mediawiki-config@master] InitialiseSettings-labs: Set values for renamed PageTriage variable

https://gerrit.wikimedia.org/r/965395

Change 965395 merged by jenkins-bot:

[operations/mediawiki-config@master] InitialiseSettings-labs: Set values for renamed PageTriage variable

https://gerrit.wikimedia.org/r/965395

jsn.sherman updated Other Assignee, added: jsn.sherman.
jsn.sherman updated the task description. (Show Details)
jsn.sherman changed the task status from In Progress to Stalled.Oct 24 2023, 1:16 PM
jsn.sherman moved this task from Eng review to Ready on the Moderator-Tools-Team (Kanban) board.
jsn.sherman subscribed.

To err on the side of caution, we will not remove the old variable from wmf config until after the train rolls out with the new variable name in the extension. Marking as stalled until then.

Change 960161 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Rename the $wgPageTriageEnableEnglishWikipediaFeatures variable

https://gerrit.wikimedia.org/r/960161

I verified that this is working as expected in beta:

enwiki, which has pagetriage and the extended features enabled, works with all features:
https://en.wikipedia.beta.wmflabs.org/wiki/Special:NewPagesFeed

zhwiki, which has pagetriage enabled, but extended features disabled, works with the limited feature set:
https://zh.wikipedia.beta.wmflabs.org/w/index.php?title=Special:%E6%96%B0%E9%A1%B5%E9%9D%A2%E4%BE%9B%E7%BB%99

testwiki, which has pagetriage and the extended features enabled even though they should be disabled, breaks:
https://test.wikipedia.beta.wmflabs.org/wiki/Special:NewPagesFeed

zhwiki has PageTraige enabled? I didn't know that. Is it just on beta cluster or also in production? Is there an operations repo file where these enablings are listed?

I wonder why the new pages feed is broken on beta cluster testwiki.

zhwiki has PageTraige enabled? I didn't know that. Is it just on beta cluster or also in production?

beta-only

Is there an operations repo file where these enablings are listed?

There is a repo, but the configurations don't have a single file as a source of truth. Config exists in multiple files and arrays get merged to produce the live config.
https://gerrit.wikimedia.org/r/plugins/gitiles/operations/mediawiki-config/+/refs/heads/master/wmf-config/
beta has a bunch of overrides of the production config, including setting different defaults, then individual wikis have their own config arrays to vary from those defaults. you can see zhwiki in beta here:
https://gerrit.wikimedia.org/r/plugins/gitiles/operations/mediawiki-config/+/refs/heads/master/wmf-config/InitialiseSettings-labs.php#1508
you can see the enabled production wikis here (just en and test wikis):
https://gerrit.wikimedia.org/r/plugins/gitiles/operations/mediawiki-config/+/refs/heads/master/wmf-config/InitialiseSettings.php#7414

I wonder why the new pages feed is broken on beta cluster testwiki.

It looks like an ores issue:
the api request
https://test.wikipedia.beta.wmflabs.org/w/api.php?action=pagetriagelist&format=json&namespace=0&showunreviewed=1&showothers=1&formatversion=2&offset=0&pageoffset=0
returns

{
    "error": {
        "code": "internal_api_error_InvalidArgumentException",
        "info": "[ZTfS3q58IA6sSvugq-vbKAAAABY] Exception caught: No model available for [articlequality]",
        "errorclass": "InvalidArgumentException",
        "trace": "InvalidArgumentException at /srv/mediawiki/php-master/extensions/ORES/includes/Storage/SqlModelLookup.php(42)\nfrom /srv/mediawiki/php-master/extensions/ORES/includes/Storage/SqlModelLookup.php(42)\n#0 /srv/mediawiki/php-master/extensions/ORES/includes/Services/PopulatedSqlModelLookup.php(114): ORES\\Storage\\SqlModelLookup->getModelId(string)\n#1 /srv/mediawiki/php-master/extensions/PageTriage/includes/OresMetadata.php(218): ORES\\Services\\PopulatedSqlModelLookup->getModelId(string)\n#2 /srv/mediawiki/php-master/extensions/PageTriage/includes/OresMetadata.php(181): MediaWiki\\Extension\\PageTriage\\OresMetadata->getORESScores(string, array)\n#3 /srv/mediawiki/php-master/extensions/PageTriage/includes/OresMetadata.php(96): MediaWiki\\Extension\\PageTriage\\OresMetadata->fetchScores(array)\n#4 /srv/mediawiki/php-master/extensions/PageTriage/includes/OresMetadata.php(110): MediaWiki\\Extension\\PageTriage\\OresMetadata->__construct(ORES\\Storage\\ThresholdLookup, ORES\\Services\\PopulatedSqlModelLookup, array, DerivativeContext, array)\n#5 /srv/mediawiki/php-master/extensions/PageTriage/includes/Api/ApiPageTriageList.php(87): MediaWiki\\Extension\\PageTriage\\OresMetadata::newFromGlobalState(DerivativeContext, array)\n#6 /srv/mediawiki/php-master/includes/api/ApiMain.php(1931): MediaWiki\\Extension\\PageTriage\\Api\\ApiPageTriageList->execute()\n#7 /srv/mediawiki/php-master/includes/api/ApiMain.php(908): ApiMain->executeAction()\n#8 /srv/mediawiki/php-master/includes/api/ApiMain.php(879): ApiMain->executeActionWithErrorHandling()\n#9 /srv/mediawiki/php-master/api.php(95): ApiMain->execute()\n#10 /srv/mediawiki/php-master/api.php(48): wfApiMain()\n#11 /srv/mediawiki/w/api.php(3): require(string)\n#12 {main}"
    },
    "servedby": "deployment-mediawiki11"
}

Test wiki on Patch demo by MPGuy2824 using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/32e9cb7926/w/

Change 968397 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[operations/mediawiki-config@master] [DNM] InitialiseSettings-labs: Remove values for renamed PageTriage variable

https://gerrit.wikimedia.org/r/968397

Change 968792 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] Rename the $wgPageTriageEnableEnglishWikipediaFeatures variable

https://gerrit.wikimedia.org/r/968792

Change 968792 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Rename the $wgPageTriageEnableEnglishWikipediaFeatures variable

https://gerrit.wikimedia.org/r/968792

Change 968397 merged by jenkins-bot:

[operations/mediawiki-config@master] InitialiseSettings-labs: Remove values for renamed PageTriage variable

https://gerrit.wikimedia.org/r/968397