In T328288#8679320, @Joe wrote:In T328288#8679125, @kostajh wrote:In T328288#8671424, @gerritbot wrote:Change 894043 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] levelingup: Keep going notification
SRE, the above job uses jobReleaseTimestamp, does that need special handling anywhere in e.g. the operations/deployment-charts/changeprop service, or should it "just work"?
The job is enqueued on account registration with a jobReleaseTimestamp of 48 hours later.
jobReleaseTimestamp is supported by changeprop, via the delay_until parameter we add to the jobs via the eventbus extension:
https://gerrit.wikimedia.org/g/mediawiki/extensions/EventBus/+/4bc310d352129be192c10c23b7a64b06aea71bf3/includes/EventFactory.php#1105so it works out of the box, but we will need to add a stanza to changeprop-jobqueue's deployment similar to what you already did in https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/636078 so that:
- This job gets a dedicated worker and doesn't block execution of other jobs
- You can add a reenqueue_delay configuration larger than the delay of the job, so that we avoid having changeprop reenqueueing jobs that are just delayed.
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | KStoller-WMF | T248330 [EPIC] Growth: Positive reinforcement | |||
Open | None | T317813 [EPIC] Positive Reinforcement: Leveling Up | |||
Resolved | KMorgan-WMF | T322435 Leveling Up: "Get started" notification | |||
Resolved | kostajh | T328288 Leveling up: "Keep going" notification | |||
Resolved | MShilova_WMF | T330420 Leveling Up - Release Readiness Checklist | |||
Resolved | kostajh | T332317 Leveling Up: Release blockers | |||
Resolved | kostajh | T331616 changeprop configuration for notificationGetStartedJob and notificationKeepGoingJob |
Event Timeline
Change 896091 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[operations/deployment-charts@master] changeprop: Add rules for notificationKeepGoingJob
Change 896091 merged by jenkins-bot:
[operations/deployment-charts@master] changeprop: Rules for notificationKeepGoingJob and notificationGetStartedJob
Change 901202 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[operations/deployment-charts@master] changeprop-jobqueue: Bump version
Change 901202 abandoned by Kosta Harlan:
[operations/deployment-charts@master] changeprop-jobqueue: Bump version
Reason:
I tried and failed to deploy the changeprop-jobqueue patch, then @hnowlan identified an issue with the deployment chart and found a workaround; thank you! There is a follow-up patch https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/901246/ for the issue we ran into. For Growth team's purposes, this task can be resolved. cc @Etonkovidova