Page MenuHomePhabricator

changeprop configuration for notificationGetStartedJob and notificationKeepGoingJob
Closed, ResolvedPublic


Change 894043 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] levelingup: Keep going notification

SRE, the above job uses jobReleaseTimestamp, does that need special handling anywhere in e.g. the operations/deployment-charts/changeprop service, or should it "just work"?

The job is enqueued on account registration with a jobReleaseTimestamp of 48 hours later.

jobReleaseTimestamp is supported by changeprop, via the delay_until parameter we add to the jobs via the eventbus extension:

so it works out of the box, but we will need to add a stanza to changeprop-jobqueue's deployment similar to what you already did in so that:

  1. This job gets a dedicated worker and doesn't block execution of other jobs
  2. You can add a reenqueue_delay configuration larger than the delay of the job, so that we avoid having changeprop reenqueueing jobs that are just delayed.

Event Timeline

Change 896091 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/deployment-charts@master] changeprop: Add rules for notificationKeepGoingJob

kostajh renamed this task from changeprop configuration for "Keep going" notification to changeprop configuration for notificationGetStartedJob and notificationKeepGoingJob.Thu, Mar 9, 1:25 PM
kostajh moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Change 896091 merged by jenkins-bot:

[operations/deployment-charts@master] changeprop: Rules for notificationKeepGoingJob and notificationGetStartedJob

We still need to deploy this, so marking as a release blocker.

Change 901202 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/deployment-charts@master] changeprop-jobqueue: Bump version

Change 901202 abandoned by Kosta Harlan:

[operations/deployment-charts@master] changeprop-jobqueue: Bump version


This comment was removed by kostajh.
kostajh triaged this task as Medium priority.Mon, Mar 20, 4:51 PM
kostajh added subscribers: hnowlan, Etonkovidova.

I tried and failed to deploy the changeprop-jobqueue patch, then @hnowlan identified an issue with the deployment chart and found a workaround; thank you! There is a follow-up patch for the issue we ran into. For Growth team's purposes, this task can be resolved. cc @Etonkovidova