Page MenuHomePhabricator

Revisit the order in which "Add topic" and "Add languages" buttons appear in sticky header
Closed, DuplicatePublic

Description

T267444 introduced changes to where and how the Add topic button appears on talk pages.

T304187 added the Add topic button to the sticky header the Vector (2022) skin introduced.

...this task involves the work with deciding whether the "Add topic" and "Add languages" buttons should appear within the sticky header in the same order they appear within the "body" of the page.

Behavior

Current✅Expected
Sticky header
Screenshot 2023-03-07 at 4.02.55 PM.png (890×1 px, 352 KB)
The Add topic button should appear to the right of the Add languages button in LTR languages and on the left of Add languages button in RTL languages
Page "body"
Screen Recording 2023-03-07 at 3.49.48 PM.mov.gif (888×1 px, 576 KB)
No changes

Context

@Edtadros noticed the inconsistency this ticket is intended to potentially resolve in T267444#8658840.

Event Timeline

Looks good. One minor thing is that you left out the language selector + new topic in sticky header case, which actually already exists, but the buttons are just the other way round. I think you should align the third mockup with this, as it’d be confusing if the buttons switched place when one starts to scroll down.

Screenshot 2022-08-11 at 21-00-35 Wikipedia Village pump (miscellaneous) - Wikipedia.png (373×1 px, 139 KB)

Actually I noticed this inconsistency first, back in August last year… And my opinion hasn’t changed since then.

ppelberg updated the task description. (Show Details)
ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.

Change 902512 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Vector@master] Fix order of language menu and add topic in sticky header

https://gerrit.wikimedia.org/r/902512