Deprecate ParserOutput::getCategories() for external use
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	cscott
	Mar 10 2023, 2:53 PM

Description

The ParserOutput::getCategories() method return a reference to an internal private property, as well as exposing a caller 'gotcha' in so far as numeric category names are stored as 'int' not 'string' in the array keys.

Details

	Subject	Repo	Branch	Lines +/-
	Update deprecated ParserOutput::getCategories()	mediawiki/extensions/Translate	master	+12 -2
	Deprecate ParserOutput::getCategories()	mediawiki/core	master	+22 -0

Customize query in gerrit

Event Timeline

cscott created this task.Mar 10 2023, 2:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2023, 2:53 PM

Change 896361 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Deprecate ParserOutput::getCategories()

https://gerrit.wikimedia.org/r/896361

gerritbot added a project: Patch-For-Review.Mar 10 2023, 2:53 PM

Aklapper added a project: Technical-Debt.Mar 10 2023, 3:20 PM

Change 896361 merged by jenkins-bot:

[mediawiki/core@master] Deprecate ParserOutput::getCategories()

https://gerrit.wikimedia.org/r/896361

Maintenance_bot removed a project: Patch-For-Review.Mar 10 2023, 5:10 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 10 2023, 6:00 PM

Change 904054 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Update deprecated ParserOutput::getCategories()

https://gerrit.wikimedia.org/r/904054

gerritbot added a project: Patch-For-Review.Mar 29 2023, 7:53 AM

Change 904054 merged by jenkins-bot: