⚓ T331762 Remove FlaggedRevs for ptwikisource

	Subject	Repo	Branch	Lines +/-
	Remove FlaggedRevs from ptwikisource	operations/mediawiki-config	master	+33 -13
	Remove FlaggedRevs for ptwikisource	operations/mediawiki-config	master	+0 -11

Status	Assigned	Task
Resolved	Kizule	T331762 Remove FlaggedRevs for ptwikisource
Resolved	BTullis	T332596 Drop several views from ptwikisource
Resolved	• Marostegui	T332594 Drop FlaggedRevs tables in database for ptwikisource

Albertoleoncio created this task.Mar 11 2023, 1:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2023, 1:37 AM

TheresNoTime claimed this task.Mar 11 2023, 3:18 AM

TheresNoTime moved this task from Backlog to Working on on the Wikimedia-Site-requests board.

Anoop changed the subtype of this task from "Administrative Request" to "Task".Mar 11 2023, 8:37 AM

TheresNoTime removed TheresNoTime as the assignee of this task.Mar 14 2023, 12:33 PM

TheresNoTime subscribed.

Anoop moved this task from Working on to Backlog on the Wikimedia-Site-requests board.Mar 14 2023, 12:46 PM

Anoop claimed this task.Mar 14 2023, 1:23 PM

Change 898719 had a related patch set uploaded (by Anzx; author: Anzx):

[operations/mediawiki-config@master] Remove FlaggedRevs for ptwikisource

https://gerrit.wikimedia.org/r/898719

gerritbot added a project: Patch-For-Review.Mar 14 2023, 1:31 PM

Anoop removed Anoop as the assignee of this task.Mar 14 2023, 5:09 PM

Anoop subscribed.

Change 898719 abandoned by Anzx:

[operations/mediawiki-config@master] Remove FlaggedRevs for ptwikisource

Reason:

https://gerrit.wikimedia.org/r/898719

Anoop removed a project: Patch-For-Review.Mar 14 2023, 5:11 PM

Let me try this, I didn't work on configuration for a very long time.

Restricted Application added a project: User-Kizule. · View Herald TranscriptMar 14 2023, 5:12 PM

Kizule moved this task from Inbox to Working on on the User-Kizule board.Mar 14 2023, 5:12 PM

Kizule moved this task from Backlog to Working on on the Wikimedia-Site-requests board.

@Albertoleoncio There are questions pending, I just remembered procedure when I was removing FlaggedRevs from srwikinews.

Do you want patrolling option (like on Wikipedia) to be enabled back? With autopatrol, patroller and rollbacker rights.
If extension won't be enabled again, do you want FlaggedRevs tables from database to be removed?

There aren't so much users with FlaggedRevs related user rights, so this won't be hard to do.

P45871 T331762

1	MariaDB [ptwikisource_p]> SELECT * FROM user_groups WHERE ug_group='autoreview';
2	+---------+------------+-----------+
3	\| ug_user \| ug_group \| ug_expiry \|
4	+---------+------------+-----------+
5	\| 5 \| autoreview \| NULL \|
6	\| 7 \| autoreview \| NULL \|
7	\| 38 \| autoreview \| NULL \|
8	\| 103 \| autoreview \| NULL \|
9	\| 208 \| autoreview \| NULL \|
10	\| 252 \| autoreview \| NULL \|
11	\| 341 \| autoreview \| NULL \|
12	\| 469 \| autoreview \| NULL \|
13	\| 488 \| autoreview \| NULL \|
14	\| 1615 \| autoreview \| NULL \|
15	\| 3455 \| autoreview \| NULL \|
16	\| 4262 \| autoreview \| NULL \|
17	\| 4676 \| autoreview \| NULL \|
18	\| 5797 \| autoreview \| NULL \|
19	\| 6739 \| autoreview \| NULL \|
20	\| 6798 \| autoreview \| NULL \|
21	\| 7306 \| autoreview \| NULL \|
22	\| 7768 \| autoreview \| NULL \|
23	\| 7988 \| autoreview \| NULL \|
24	\| 8021 \| autoreview \| NULL \|
25	\| 8569 \| autoreview \| NULL \|
26	\| 9069 \| autoreview \| NULL \|
27	\| 10540 \| autoreview \| NULL \|
28	\| 10626 \| autoreview \| NULL \|
29	\| 11859 \| autoreview \| NULL \|
30	\| 12097 \| autoreview \| NULL \|
31	\| 12344 \| autoreview \| NULL \|
32	\| 12516 \| autoreview \| NULL \|
33	\| 12681 \| autoreview \| NULL \|
34	\| 13039 \| autoreview \| NULL \|
35	\| 13172 \| autoreview \| NULL \|
36	\| 14235 \| autoreview \| NULL \|
37	\| 15288 \| autoreview \| NULL \|
38	\| 19404 \| autoreview \| NULL \|
39	\| 26857 \| autoreview \| NULL \|
40	\| 28173 \| autoreview \| NULL \|
41	\| 28449 \| autoreview \| NULL \|
42	\| 30847 \| autoreview \| NULL \|
43	\| 34291 \| autoreview \| NULL \|
44	\| 34905 \| autoreview \| NULL \|
45	\| 35965 \| autoreview \| NULL \|
46	+---------+------------+-----------+
47	41 rows in set (0.003 sec)
48
49	MariaDB [ptwikisource_p]>
50
51	MariaDB [ptwikisource_p]> SELECT * FROM user_groups WHERE ug_group='reviewer';
52	+---------+----------+-----------+
53	\| ug_user \| ug_group \| ug_expiry \|
54	+---------+----------+-----------+
55	\| 7 \| reviewer \| NULL \|
56	\| 38 \| reviewer \| NULL \|
57	\| 162 \| reviewer \| NULL \|
58	\| 208 \| reviewer \| NULL \|
59	\| 351 \| reviewer \| NULL \|
60	\| 986 \| reviewer \| NULL \|
61	\| 1140 \| reviewer \| NULL \|
62	\| 1753 \| reviewer \| NULL \|
63	\| 2399 \| reviewer \| NULL \|
64	\| 2456 \| reviewer \| NULL \|
65	\| 4617 \| reviewer \| NULL \|
66	\| 9321 \| reviewer \| NULL \|
67	+---------+----------+-----------+
68	12 rows in set (0.002 sec)
69
70	MariaDB [ptwikisource_p]>
71
72	MariaDB [ptwikisource_p]> SELECT * FROM user_groups WHERE ug_group='editor';
73	+---------+----------+-----------+
74	\| ug_user \| ug_group \| ug_expiry \|
75	+---------+----------+-----------+
76	\| 7 \| editor \| NULL \|
77	\| 38 \| editor \| NULL \|
78	\| 103 \| editor \| NULL \|
79	\| 162 \| editor \| NULL \|
80	\| 208 \| editor \| NULL \|
81	\| 228 \| editor \| NULL \|
82	\| 341 \| editor \| NULL \|
83	\| 351 \| editor \| NULL \|
84	\| 469 \| editor \| NULL \|
85	\| 986 \| editor \| NULL \|
86	\| 1095 \| editor \| NULL \|
87	\| 1140 \| editor \| NULL \|
88	\| 1333 \| editor \| NULL \|
89	\| 1753 \| editor \| NULL \|
90	\| 1799 \| editor \| NULL \|
91	\| 2399 \| editor \| NULL \|
92	\| 2456 \| editor \| NULL \|
93	\| 2890 \| editor \| NULL \|
94	\| 3513 \| editor \| NULL \|
95	\| 3660 \| editor \| NULL \|
96	\| 4262 \| editor \| NULL \|
97	\| 4462 \| editor \| NULL \|
98	\| 4617 \| editor \| NULL \|
99	\| 4676 \| editor \| NULL \|
100	\| 5109 \| editor \| NULL \|
101	\| 5571 \| editor \| NULL \|
102	\| 5797 \| editor \| NULL \|
103	\| 6303 \| editor \| NULL \|
104	\| 6719 \| editor \| NULL \|
105	\| 6798 \| editor \| NULL \|
106	\| 7306 \| editor \| NULL \|
107	\| 7450 \| editor \| NULL \|
108	\| 7489 \| editor \| NULL \|
109	\| 7768 \| editor \| NULL \|
110	\| 7988 \| editor \| NULL \|
111	\| 8021 \| editor \| NULL \|
112	\| 8569 \| editor \| NULL \|
113	\| 9069 \| editor \| NULL \|
114	\| 9321 \| editor \| NULL \|
115	\| 10626 \| editor \| NULL \|
116	\| 11978 \| editor \| NULL \|
117	\| 12097 \| editor \| NULL \|
118	\| 12516 \| editor \| NULL \|
119	\| 14235 \| editor \| NULL \|
120	\| 17561 \| editor \| NULL \|
121	\| 19404 \| editor \| NULL \|
122	\| 24393 \| editor \| NULL \|
123	\| 26857 \| editor \| NULL \|
124	\| 28173 \| editor \| NULL \|
125	\| 28257 \| editor \| NULL \|
126	\| 28449 \| editor \| NULL \|
127	\| 30049 \| editor \| NULL \|
128	\| 30847 \| editor \| NULL \|
129	\| 35105 \| editor \| NULL \|
130	\| 35938 \| editor \| NULL \|
131	+---------+----------+-----------+
132	55 rows in set (0.002 sec)
133
134	MariaDB [ptwikisource_p]>

(Following T209251: Remove FlaggedRevs and add back rights autopatrolled, patroller (with enabled RCPatrol), rollbacker on srwikinews).

List of FlaggedRevs related tables for DBA to remove:

flaggedpage_config
flaggedpage_pending
flaggedpages
flaggedrevs
flaggedrevs_promote
flaggedrevs_statistics
flaggedrevs_tracking
flaggedtemplates

I'm hoping that I didn't forget anything. Pinging @Marostegui just to make sure about everything.

That looks right to me, this is the list of table on a wiki with flaggedrevs enabled:

root@db1110.eqiad.wmnet[dewiki]> show tables like 'flagged%';
+-----------------------------+
| Tables_in_dewiki (flagged%) |
+-----------------------------+
| flaggedpage_config          |
| flaggedpage_pending         |
| flaggedpages                |
| flaggedrevs                 |
| flaggedrevs_promote         |
| flaggedrevs_statistics      |
| flaggedrevs_tracking        |
| flaggedtemplates            |
+-----------------------------+
8 rows in set (0.001 sec)

Kizule moved this task from Working on to Watching on the User-Kizule board.Mar 15 2023, 9:05 AM

@Kizule

Do you want patrolling option (like on Wikipedia) to be enabled back? With autopatrol, patroller and rollbacker rights.

I myself don't believe it's necessary, as we don't even have users to patrol edits. However, I think it's useful to keep the editor group and associate it with an intermediate level of protection for pages (between autoconfirmed and sysop). I imagine this requires another ticket, but the group could be maintained without any special privileges until then.

If extension won't be enabled again, do you want FlaggedRevs tables from database to be removed?

Could we do the same thing as T209761#4812733, but keep the tables for like... 6 months? The extension would be unlikely to be reactivated again, but there wasn't exactly a big discussion and the tables are small in terms of storage, so I think keeping them for a reasonable amount of time would be convenient, just in case.

Editor is FlaggedRevs' user group, once we remove it from wiki, it will disappear. Patrolling edits is better and easier mechanism than FlaggedRevs for small and not really active wikis.

Backup will be made anyways, so I guess we are fine with this.

Editor is FlaggedRevs' user group, once we remove it from wiki, it will disappear. Patrolling edits is better and easier mechanism than FlaggedRevs for small and not really active wikis.

OK then. Let's set the patrolling option enabled.

Yeah, RC patrolling is highly recommended. You can add auto-patrolled group and such similar to the default config.

In T331762#8704669, @Ladsgroup wrote:

Yeah, RC patrolling is highly recommended. You can add auto-patrolled group and such similar to the default config.

Yeah, I was going to add autopatrol, patroller and rollbacker, and on deployment, someone to run maintenance script to fix groups.

Change 900696 had a related patch set uploaded (by Zoranzoki21; author: Zoranzoki21):

[operations/mediawiki-config@master] [WIP] Remove FlaggedRevs from ptwikisource

https://gerrit.wikimedia.org/r/900696

gerritbot added a project: Patch-For-Review.Mar 17 2023, 4:33 PM

Change 900696 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove FlaggedRevs from ptwikisource

https://gerrit.wikimedia.org/r/900696

Mentioned in SAL (#wikimedia-operations) [2023-03-20T13:49:05Z] <samtar@deploy2002> Started scap: Backport for [[gerrit:776200|Remove meaningless restriction level "none"]], [[gerrit:900696|Remove FlaggedRevs from ptwikisource (T331762)]]

Mentioned in SAL (#wikimedia-operations) [2023-03-20T13:50:31Z] <samtar@deploy2002> thiemowmde and samtar and zoranzoki21: Backport for [[gerrit:776200|Remove meaningless restriction level "none"]], [[gerrit:900696|Remove FlaggedRevs from ptwikisource (T331762)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-03-20T13:58:49Z] <samtar@deploy2002> Finished scap: Backport for [[gerrit:776200|Remove meaningless restriction level "none"]], [[gerrit:900696|Remove FlaggedRevs from ptwikisource (T331762)]] (duration: 09m 44s)

Mentioned in SAL (#wikimedia-operations) [2023-03-20T14:00:03Z] <TheresNoTime> [samtar@mwmaint2002 ~]$ mwscript maintenance/emptyUserGroup.php --wiki ptwikisource editor T331762

Mentioned in SAL (#wikimedia-operations) [2023-03-20T14:01:14Z] <TheresNoTime> [samtar@mwmaint2002 ~]$ mwscript maintenance/migrateUserGroup.php --wiki ptwikisource 'autoreviewer' 'autopatrol' ("nothing to do") T331762

Mentioned in SAL (#wikimedia-operations) [2023-03-20T14:01:44Z] <TheresNoTime> [samtar@mwmaint2002 ~]$ mwscript maintenance/migrateUserGroup.php --wiki ptwikisource 'reviewer' 'patrol' T331762

Script output:

P45895 Maintenance scripts for T331762

1	[samtar@mwmaint2002 ~]$ mwscript maintenance/emptyUserGroup.php --wiki ptwikisource editor
2
3	*******************************************************************************
4	NOTE: Do not run maintenance scripts directly, use maintenance/run.php instead!
5	Running scripts directly has been deprecated in MediaWiki 1.40.
6	It may not work for some (or any) scripts in the future.
7	*******************************************************************************
8
9	Removing users from editor...
10	...done! Removed 55 users in total.
11	[samtar@mwmaint2002 ~]$ mwscript maintenance/migrateUserGroup.php --wiki ptwikisource 'autoreviewer' 'autopatrol'
12
13	*******************************************************************************
14	NOTE: Do not run maintenance scripts directly, use maintenance/run.php instead!
15	Running scripts directly has been deprecated in MediaWiki 1.40.
16	It may not work for some (or any) scripts in the future.
17	*******************************************************************************
18
19	Nothing to do - no users in the 'autoreviewer' group
20	[samtar@mwmaint2002 ~]$ mwscript maintenance/migrateUserGroup.php --wiki ptwikisource 'reviewer' 'patrol'
21
22	*******************************************************************************
23	NOTE: Do not run maintenance scripts directly, use maintenance/run.php instead!
24	Running scripts directly has been deprecated in MediaWiki 1.40.
25	It may not work for some (or any) scripts in the future.
26	*******************************************************************************
27
28	Doing users 7 to 206
29	Doing users 207 to 406
30	Doing users 407 to 606
31	Doing users 607 to 806
32	Doing users 807 to 1006
33	Doing users 1007 to 1206
34	Doing users 1207 to 1406
35	Doing users 1407 to 1606
36	Doing users 1607 to 1806
37	Doing users 1807 to 2006
38	Doing users 2007 to 2206
39	Doing users 2207 to 2406
40	Doing users 2407 to 2606
41	Doing users 2607 to 2806
42	Doing users 2807 to 3006
43	Doing users 3007 to 3206
44	Doing users 3207 to 3406
45	Doing users 3407 to 3606
46	Doing users 3607 to 3806
47	Doing users 3807 to 4006
48	Doing users 4007 to 4206
49	Doing users 4207 to 4406
50	Doing users 4407 to 4606
51	Doing users 4607 to 4806
52	Doing users 4807 to 5006
53	Doing users 5007 to 5206
54	Doing users 5207 to 5406
55	Doing users 5407 to 5606
56	Doing users 5607 to 5806
57	Doing users 5807 to 6006
58	Doing users 6007 to 6206
59	Doing users 6207 to 6406
60	Doing users 6407 to 6606
61	Doing users 6607 to 6806
62	Doing users 6807 to 7006
63	Doing users 7007 to 7206
64	Doing users 7207 to 7406
65	Doing users 7407 to 7606
66	Doing users 7607 to 7806
67	Doing users 7807 to 8006
68	Doing users 8007 to 8206
69	Doing users 8207 to 8406
70	Doing users 8407 to 8606
71	Doing users 8607 to 8806
72	Doing users 8807 to 9006
73	Doing users 9007 to 9206
74	Doing users 9207 to 9406
75	Done! 12 users in group 'reviewer' are now in 'patrol' instead.

Mentioned in SAL (#wikimedia-operations) [2023-03-20T14:05:55Z] <TheresNoTime> [samtar@mwmaint2002 ~]$ mwscript maintenance/migrateUserGroup.php --wiki ptwikisource 'autoreview' 'autopatrol' T331762

In T331762#8710102, @Stashbot wrote:

Mentioned in SAL (#wikimedia-operations) [2023-03-20T14:05:55Z] <TheresNoTime> [samtar@mwmaint2002 ~]$ mwscript maintenance/migrateUserGroup.php --wiki ptwikisource 'autoreview' 'autopatrol' T331762

[samtar@mwmaint2002 ~]$ mwscript maintenance/migrateUserGroup.php --wiki ptwikisource 'autoreview' 'autopatrol'

*******************************************************************************
NOTE: Do not run maintenance scripts directly, use maintenance/run.php instead!
      Running scripts directly has been deprecated in MediaWiki 1.40.
      It may not work for some (or any) scripts in the future.
*******************************************************************************

Doing users 5 to 204
Doing users 205 to 404
Doing users 405 to 604
Doing users 605 to 804
Doing users 805 to 1004
Doing users 1005 to 1204
Doing users 1205 to 1404
Doing users 1405 to 1604
Doing users 1605 to 1804
Doing users 1805 to 2004
Doing users 2005 to 2204
Doing users 2205 to 2404
Doing users 2405 to 2604
Doing users 2605 to 2804
Doing users 2805 to 3004
Doing users 3005 to 3204
Doing users 3205 to 3404
Doing users 3405 to 3604
Doing users 3605 to 3804
Doing users 3805 to 4004
Doing users 4005 to 4204
Doing users 4205 to 4404
Doing users 4405 to 4604
Doing users 4605 to 4804
Doing users 4805 to 5004
Doing users 5005 to 5204
Doing users 5205 to 5404
Doing users 5405 to 5604
Doing users 5605 to 5804
Doing users 5805 to 6004
Doing users 6005 to 6204
Doing users 6205 to 6404
Doing users 6405 to 6604
Doing users 6605 to 6804
Doing users 6805 to 7004
Doing users 7005 to 7204
Doing users 7205 to 7404
Doing users 7405 to 7604
Doing users 7605 to 7804
Doing users 7805 to 8004
Doing users 8005 to 8204
Doing users 8205 to 8404
Doing users 8405 to 8604
Doing users 8605 to 8804
Doing users 8805 to 9004
Doing users 9005 to 9204
Doing users 9205 to 9404
Doing users 9405 to 9604
Doing users 9605 to 9804
Doing users 9805 to 10004
Doing users 10005 to 10204
Doing users 10205 to 10404
Doing users 10405 to 10604
Doing users 10605 to 10804
Doing users 10805 to 11004
Doing users 11005 to 11204
Doing users 11205 to 11404
Doing users 11405 to 11604
Doing users 11605 to 11804
Doing users 11805 to 12004
Doing users 12005 to 12204
Doing users 12205 to 12404
Doing users 12405 to 12604
Doing users 12605 to 12804
Doing users 12805 to 13004
Doing users 13005 to 13204
Doing users 13205 to 13404
Doing users 13405 to 13604
Doing users 13605 to 13804
Doing users 13805 to 14004
Doing users 14005 to 14204
Doing users 14205 to 14404
Doing users 14405 to 14604
Doing users 14605 to 14804
Doing users 14805 to 15004
Doing users 15005 to 15204
Doing users 15205 to 15404
Doing users 15405 to 15604
Doing users 15605 to 15804
Doing users 15805 to 16004
Doing users 16005 to 16204
Doing users 16205 to 16404
Doing users 16405 to 16604
Doing users 16605 to 16804
Doing users 16805 to 17004
Doing users 17005 to 17204
Doing users 17205 to 17404
Doing users 17405 to 17604
Doing users 17605 to 17804
Doing users 17805 to 18004
Doing users 18005 to 18204
Doing users 18205 to 18404
Doing users 18405 to 18604
Doing users 18605 to 18804
Doing users 18805 to 19004
Doing users 19005 to 19204
Doing users 19205 to 19404
Doing users 19405 to 19604
Doing users 19605 to 19804
Doing users 19805 to 20004
Doing users 20005 to 20204
Doing users 20205 to 20404
Doing users 20405 to 20604
Doing users 20605 to 20804
Doing users 20805 to 21004
Doing users 21005 to 21204
Doing users 21205 to 21404
Doing users 21405 to 21604
Doing users 21605 to 21804
Doing users 21805 to 22004
Doing users 22005 to 22204
Doing users 22205 to 22404
Doing users 22405 to 22604
Doing users 22605 to 22804
Doing users 22805 to 23004
Doing users 23005 to 23204
Doing users 23205 to 23404
Doing users 23405 to 23604
Doing users 23605 to 23804
Doing users 23805 to 24004
Doing users 24005 to 24204
Doing users 24205 to 24404
Doing users 24405 to 24604
Doing users 24605 to 24804
Doing users 24805 to 25004
Doing users 25005 to 25204
Doing users 25205 to 25404
Doing users 25405 to 25604
Doing users 25605 to 25804
Doing users 25805 to 26004
Doing users 26005 to 26204
Doing users 26205 to 26404
Doing users 26405 to 26604
Doing users 26605 to 26804
Doing users 26805 to 27004
Doing users 27005 to 27204
Doing users 27205 to 27404
Doing users 27405 to 27604
Doing users 27605 to 27804
Doing users 27805 to 28004
Doing users 28005 to 28204
Doing users 28205 to 28404
Doing users 28405 to 28604
Doing users 28605 to 28804
Doing users 28805 to 29004
Doing users 29005 to 29204
Doing users 29205 to 29404
Doing users 29405 to 29604
Doing users 29605 to 29804
Doing users 29805 to 30004
Doing users 30005 to 30204
Doing users 30205 to 30404
Doing users 30405 to 30604
Doing users 30605 to 30804
Doing users 30805 to 31004
Doing users 31005 to 31204
Doing users 31205 to 31404
Doing users 31405 to 31604
Doing users 31605 to 31804
Doing users 31805 to 32004
Doing users 32005 to 32204
Doing users 32205 to 32404
Doing users 32405 to 32604
Doing users 32605 to 32804
Doing users 32805 to 33004
Doing users 33005 to 33204
Doing users 33205 to 33404
Doing users 33405 to 33604
Doing users 33605 to 33804
Doing users 33805 to 34004
Doing users 34005 to 34204
Doing users 34205 to 34404
Doing users 34405 to 34604
Doing users 34605 to 34804
Doing users 34805 to 35004
Doing users 35005 to 35204
Doing users 35205 to 35404
Doing users 35405 to 35604
Doing users 35605 to 35804
Doing users 35805 to 36004
Done! 41 users in group 'autoreview' are now in 'autopatrol' instead.

Mentioned in SAL (#wikimedia-operations) [2023-03-20T14:08:56Z] <TheresNoTime> [samtar@mwmaint2002 ~]$ mwscript maintenance/migrateUserGroup.php --wiki ptwikisource 'autopatrol' 'autopatrolled' T331762