Page MenuHomePhabricator

Wikibase Repository: Collapse button have different height of site link group header in sitelinks view
Open, Needs TriagePublicBUG REPORT

Description

Follow-up of T329167: Wikibase Repository: The collapse button in sitelinks view become invisible, overlapped by the sitelinks heading .

Steps to replicate the issue (include links if applicable):

  • Check the site group link header and the collapse button

What happens?:

It looks a little not that good as the height of the toggle does not exactly match the header.

I was testing something else and it just look like that, clearly not the same height:

image.png (65×537 px, 4 KB)

Ah yes, when actively giving the parent a different background-color. I agree that it would be nice for them to be aligned, both for something like dark-mode or things like Windows High Contrast Mode (WHCM), but it might be surprisingly finicky to align them properly and consistently, especially with regard to text-only zooming.

So I think we should move forward with this change at is right now, given that this issue is entirely invisible for everyone not changing the background color, and it already provides a significant boost in value and functionality.

I'm open to follow-up patches that tackle the height difference specifically, but I don't think we should block this patch because of that.

What should have happened instead?:

The header and the collapse toggle should have the same height.

NOTE: The header might have line wrap, so it's not a fixed height.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):