Page MenuHomePhabricator
Create Task
Maniphest T331824

Export in native format on Special:ExportTranslations results in an empty .json file if messages do not exist
Closed, ResolvedPublic4 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Go to Special:Translate
  • Click on 'Export', among the links on the the top right corner of the page which opens Special:ExportTranslations
  • Select the Mobile Frontend - User interface group from dropdown menu
  • Select a language to export such as Kikuyu - ki
  • Select 'Export in native format'
  • Finally, click on 'Fetch'

Screen Shot 2023-03-30 at 08.42.56 AM.png (402×1 px, 36 KB)

What happens?:
A .json file is downloaded. Opening the .json file may* reveal that the file is empty if the message group contains no messages to export.

What should have happened instead
If the group selected contains no messages to be translated in the selected language an error message should be displayed to the user notifying them so.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Special:ExportTranslations: Show error message if nothing to exportmediawiki/extensions/Translatemaster+20 -7
Customize query in gerrit

Event Timeline

Wangombe created this task.Mar 12 2023, 7:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2023, 7:02 PM
Wangombe renamed this task from Export in native format on Special:ExportTranslations results in an empty .json file to Export in native format on Special:ExportTranslations results in an empty .json file if messages do not exist.Mar 13 2023, 6:44 AM
Wangombe updated the task description. (Show Details)Mar 13 2023, 7:11 AM
Nikerabbit triaged this task as Low priority.Mar 13 2023, 3:17 PM
Nikerabbit removed a project: Language-Team (Language-2022-April-June).
Nikerabbit updated the task description. (Show Details)
Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.
Tacsipacsi subscribed.Mar 13 2023, 9:57 PM

I tried to replicate the issue:

  1. went to Special:Translate;
  2. clicked on Export, which took me to Special:ExportTranslations;
  3. selected a group, namely Help:Authority control;
  4. selected a language, namely Croatian (hr);
  5. selected Export in native format;
  6. pressed Fetch;

but I got an error message about the specified export format not being supported, not an empty JSON file. Please be more precise.

Wangombe updated the task description. (Show Details)Mar 30 2023, 5:47 AM
Wangombe added a comment.Mar 30 2023, 7:24 AM
In T331824#8689855, @Tacsipacsi wrote:

I tried to replicate the issue:
...
but I got an error message about the specified export format not being supported, not an empty JSON file. Please be more precise.

I think an error message would be more appropriate to display instead of downloading a file with 'empty' json content.

Wangombe updated the task description. (Show Details)Mar 30 2023, 7:25 AM
Wangombe set the point value for this task to 4.Apr 4 2023, 8:06 AM
Nikerabbit added a project: Language-Team (Language-2023-April-June).Apr 4 2023, 11:32 AM
Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2023-April-June) board.Apr 4 2023, 11:59 AM
Wangombe added a comment.Apr 4 2023, 12:01 PM

After some investigation, this seems to only occur for message groups that are FileBasedMessageGroup::class instance. The error message about "the specified export format not being supported", Should appear where the message group being exported is not an instance of FileBasedMessageGroup.

Nikerabbit lowered the priority of this task from Low to Lowest.Apr 4 2023, 12:06 PM
Wangombe changed the task status from Open to In Progress.Apr 18 2023, 7:23 AM
Wangombe claimed this task.
Wangombe moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2023-April-June) board.
gerritbot added a comment.Apr 19 2023, 11:29 AM

Change 909986 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Special:ExportTranslations show error message if empty

https://gerrit.wikimedia.org/r/909986

gerritbot added a project: Patch-For-Review.Apr 19 2023, 11:29 AM
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2023-April-June) board.Apr 24 2023, 4:47 AM
Wangombe added a comment.EditedApr 25 2023, 12:46 PM

image.png (503×1 px, 30 KB)
Here is the output using the DiscordWikiBot and a language that the messages don't exist in, ki.

gerritbot added a comment.Apr 25 2023, 1:40 PM

Change 909986 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:ExportTranslations: Show error message if nothing to export

https://gerrit.wikimedia.org/r/909986

Maintenance_bot removed a project: Patch-For-Review.Apr 25 2023, 2:11 PM
abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2023-April-June) board.Apr 25 2023, 2:12 PM
Wangombe closed this task as Resolved.May 4 2023, 7:10 AM

Tested on translatewiki.net

Nikerabbit moved this task from Check after deployment to Done on the Language-Team (Language-2023-April-June) board.May 9 2023, 7:40 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 9:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits