Page MenuHomePhabricator

[tbs.cli] build start default builder has no tag, and does not pass the admission webhook check
Closed, ResolvedPublic

Description

dcaro@toolsbeta-sgebastion-05:~$ sudo -i -u toolsbeta.test
toolsbeta.test@toolsbeta-sgebastion-05:~$ toolforge build start https://github.com/david-caro/wm-lol.git
Traceback (most recent call last):
  File "/usr/bin/toolforge", line 8, in <module>
    sys.exit(main())
  File "/usr/lib/python3/dist-packages/toolforge_cli/cli.py", line 666, in main
    toolforge()
  File "/usr/lib/python3/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/toolforge_cli/cli.py", line 342, in wrapper
    return func(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/toolforge_cli/cli.py", line 435, in build_start
    response = _execute_k8s_client_method(method=k8s_client.create_object, kwargs=method_kwargs)
  File "/usr/lib/python3/dist-packages/toolforge_cli/cli.py", line 26, in _execute_k8s_client_method
    return method(**kwargs)
  File "/usr/lib/python3/dist-packages/toolforge_cli/k8sclient.py", line 209, in create_object
    version=K8sAPIClient.KIND_TO_VERSION[kind],
  File "/usr/lib/python3/dist-packages/toolforge_cli/k8sclient.py", line 133, in _post
    raise Exception(f"Bad request: {response.text}")
Exception: Bad request: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"admission webhook \"buildpack-admission.tools.wmcloud.org\" denied the request: Builder (gotten docker-registry.tools.wmflabs.org/toolforge-bullseye0-builder) does not match AllowedBuilders (expected paketobuildpacks/builder:base|gcr.io/buildpacks/builder:v1|docker-registry.tools.wmflabs.org/toolforge-bullseye0-builder:latest).","code":400}

This task is to change that default value to add the :latest tag to it.

Event Timeline

Change 897839 had a related patch set uploaded (by David Caro; author: David Caro):

[cloud/toolforge/toolforge-cli@main] cli: add builder tag to cli default

https://gerrit.wikimedia.org/r/897839

Change 897839 merged by jenkins-bot:

[cloud/toolforge/toolforge-cli@main] cli: add builder tag to cli default

https://gerrit.wikimedia.org/r/897839