Maniphest T331908

[follow up] Languages overlay does not need to use API.
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

None

Authored By

	Jdlrobson
	Mar 13 2023, 5:31 PM

Description

NOTE: This is follow up work to T331905. Benefits: Clicking languages on mobile will feel more responsive as no API call will be required, less JS loaded on page load.

Background

Currently clicking the language button triggers an API request to look up languages.
With T331905 and once cache has cleared, the languages will always be accessible within the page.

Doing this will reduce MobileFrontend's JavaScript footprint and make the language button feel more responsive.

TODO

Drop language overlay API lookup - instead use DOM manipulation to access languages

QA Results - Beta

AC	Status	Details
1	✅	T331908#8962050

QA Results - Prod

AC	Status	Details
1	✅	T331908#8974941

Details

	Subject	Repo	Branch	Lines +/-
	Language overlay uses page HTML	mediawiki/extensions/MobileFrontend	master	+85 -213

Customize query in gerrit

Related Objects

Mentioned In: T335030: Minerva Neue: Stop mixing variant names with language names in the language overlay
T331931: [subtask] Remove Special:MobileLanguages code from MobileFrontend
T326829: [Spike] Make languages available to index crawlers in mobile version of article pages
Mentioned Here: T331905: Make languages available to index crawlers in BODY of mobile version of article pages

Event Timeline

Jdlrobson created this task.Mar 13 2023, 5:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2023, 5:31 PM

Jdlrobson mentioned this in T326829: [Spike] Make languages available to index crawlers in mobile version of article pages.Mar 13 2023, 5:31 PM

Winston_Sung subscribed.Mar 13 2023, 5:49 PM

Jdlrobson mentioned this in T331931: [subtask] Remove Special:MobileLanguages code from MobileFrontend.Mar 13 2023, 9:33 PM

Change 898039 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Language overlay uses page HTML

https://gerrit.wikimedia.org/r/898039

gerritbot added a project: Patch-For-Review.Mar 13 2023, 11:18 PM

Jdlrobson triaged this task as Medium priority.Mar 15 2023, 5:41 PM

Jdlrobson moved this task from Backlog to Post-page tools cleanup on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Mar 21 2023, 5:55 PM

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Needs Prioritization (Tech)).Mar 21 2023, 5:57 PM

Jdlrobson moved this task from Incoming to Current Quarter on the Web-Team-Backlog board.Mar 23 2023, 4:58 PM

Jdlrobson moved this task from Current Quarter to Web Team FY2022-23 Q4 Sprint 1 on the Web-Team-Backlog board.Mar 29 2023, 6:04 PM

Jdlrobson edited projects, added Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1); removed Web-Team-Backlog.

Jdlrobson updated the task description. (Show Details)

Jdlrobson renamed this task from Languages overlay does not need to use API. to [follow up] Languages overlay does not need to use API..Mar 29 2023, 6:07 PM

ovasileva set the point value for this task to 3.Mar 30 2023, 5:56 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2); removed Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1).Apr 10 2023, 5:36 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2).Apr 24 2023, 5:36 PM

ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3).May 8 2023, 5:24 PM

Jdlrobson moved this task from Incoming to Web Team FY2022-23 Q4 Sprint 4 on the Web-Team-Backlog board.May 9 2023, 5:45 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4); removed Web-Team-Backlog.

Jdlrobson edited projects, added Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4).May 25 2023, 5:02 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6); removed Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5).May 26 2023, 9:28 AM

Bumping to high as this has been bumped several sprints now, we have a patch and this significantly improves user responsiveness/performance of the mobile site for users changing languages.

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6) board.Jun 20 2023, 4:50 PM

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6) board.Jun 20 2023, 5:34 PM

NOTE: to test this you'll need languages set up locally. MobileContentProvider will not work here.

I have the Interwiki extension enabled locally with following permission:

wfLoadExtension('Interwiki');
$wgGroupPermissions['sysop']['interwiki'] = true;

and following table on http://localhost:8888/wiki/Special:Interwiki:

I have a local wiki page with the following text:

[[es:Espagne]]

The languages on the mobile site should work with JS disabled and JS enabled.

Mabualruz claimed this task.Jun 22 2023, 4:40 PM

Change 898039 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Language overlay uses page HTML

https://gerrit.wikimedia.org/r/898039

Maintenance_bot removed a project: Patch-For-Review.Jun 22 2023, 8:11 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 22 2023, 9:00 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6) board.Jun 22 2023, 9:09 PM

Jdlrobson reassigned this task from Mabualruz to Edtadros.Jun 22 2023, 9:10 PM

Jdlrobson added a subscriber: Mabualruz.

@Jdlrobson is the verification for this task that in mobile the language selector should work with/without JS enabled?

With JS disabled the button should point to a section at the bottom of the page.

https://en.m.wikipedia.beta.wmflabs.org/wiki/Language_test should be a good page to test on!

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: With JS disabled the button should point to a section at the bottom of the page.

Screen Recording 2023-06-24 at 4.33.15 PM.mov.gif (958×1 px, 180 KB)

Edtadros updated the task description. (Show Details)Jun 25 2023, 12:28 AM

LGoto assigned this task to KSarabia-WMF.Jun 26 2023, 5:20 PM

Signing off. LGTM

KSarabia-WMF reassigned this task from KSarabia-WMF to Edtadros.Jun 27 2023, 3:15 PM

KSarabia-WMF moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6) board.

KSarabia-WMF subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: cawiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: With JS disabled the button should point to a section at the bottom of the page.

Screen Recording 2023-06-28 at 4.29.00 PM.mov.gif (950×1 px, 1003 KB)

Edtadros updated the task description. (Show Details)Jun 28 2023, 11:35 PM

Winston_Sung mentioned this in T335030: Minerva Neue: Stop mixing variant names with language names in the language overlay.Jul 21 2023, 6:09 AM

	F37122527: Screen Recording 2023-06-28 at 4.29.00 PM.mov.gif
	Jun 28 2023, 11:34 PM

	F37117750: Screen Recording 2023-06-24 at 4.33.15 PM.mov.gif
	Jun 25 2023, 12:26 AM

	F37110460: Screenshot 2023-06-20 at 10.38.52 AM.png
	Jun 20 2023, 5:39 PM

[follow up] Languages overlay does not need to use API.Closed, ResolvedPublic3 Estimated Story PointsBUG REPORTActions

Description

Background

TODO

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

[follow up] Languages overlay does not need to use API.
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions