Page MenuHomePhabricator
Create Task
Maniphest T33191

"Not logged in" p-personal javascript should not be triggered after login
Closed, ResolvedPublic
Actions

Description

Author: romaine.wiki

Description:
When I am not logged in it shows (in Dutch): Niet aangemeld Overlegpagina IP-adres Bijdragen IP-adres

When I am logged in it shows: Romaine Overleg Voorkeuren Volglijst Bijdragen Afmelden

But the first page I see when I log in is: Romaine Overleg Voorkeuren Volglijst Bijdragen Afmelden Niet aangemeld Overlegpagina IP-adres Bijdragen IP-adres

And that last one isn't correct, it shows the top two lines together.

Greetings - Romaine

Version: unspecified
Severity: normal

Details

Reference
bz31191
TitleReferenceAuthorSource BranchDest Branch
local.json: update footer links for foundation wikirepos/phabricator/deployment!4brennenfooter-updateswmf/stable
Customize query in GitLab

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:54 PM
• bzimport added a project: WMF-General-or-Unknown.
• bzimport set Reference to bz31191.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Sep 27 2011, 6:07 PM
• bzimport added a comment.Sep 27 2011, 6:08 PM

romaine.wiki wrote:

Example: http://i56.tinypic.com/2cfuk2e.png

Krinkle added a comment.Sep 27 2011, 6:49 PM

This is created by the loggedOutTalkPage() function in nl.wikipedia's MediaWiki:Common.js.

Due to bug 31192, the javascript is also run on the first page when logging in. Because of the way that javascript function works, some links are left and thus both show up.

Once bug 31192 is fixed this will automatically be fixed.

Catrope added a comment.Sep 27 2011, 7:16 PM
  • Bug 31192 has been marked as a duplicate of this bug. ***
Catrope added a comment.Sep 27 2011, 7:17 PM

It's not a JS thing. The entire interface is slowing as logged out in my tests on localhost.

Catrope added a comment.Sep 27 2011, 7:23 PM

Fixed in r98237, deploying.

Catrope added a comment.Sep 27 2011, 7:32 PM

Fix deployed, should be working again now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL