Page MenuHomePhabricator
Create Task
Maniphest T331975

Separate demo components from library components
Closed, ResolvedPublic
Actions

Description

It would be nice to have a distinct folder for the components that GrowthExperiments extension will use as a compiled library as opposed of the components that are only used in the documentation. eg: components

Related Objects
Search...

Event Timeline

Sgs created this task.Mar 14 2023, 11:05 AM
kostajh removed a project: Epic.Mar 14 2023, 11:07 AM
kostajh added a comment.Mar 15 2023, 10:51 AM

To clarify, the idea is that there is a components directory that is used by both the MediaWiki code (e.g. code that is in modules/ext.growthExperiments.StructuredTask.PreEdit/{SomeFiles}.vue) and in the demo directory (documentation/frontend/component-demos).

Both the MediaWiki extension code and the demo directory will need to import from the same shared component library.

Sgs added a comment.Mar 15 2023, 10:52 AM
In T331975#8697019, @kostajh wrote:

To clarify, the idea is that there is a components directory that is used by both the MediaWiki code (e.g. code that is in modules/ext.growthExperiments.StructuredTask.PreEdit/{SomeFiles}.vue) and in the demo directory (documentation/frontend/component-demos).

Both the MediaWiki extension code and the demo directory will need to import from the same shared component library.

The process you are describing is not possible without a build step, are you suggesting to introduce such build step within this task?

kostajh added a comment.Mar 15 2023, 10:55 AM
In T331975#8697022, @Sgs wrote:
In T331975#8697019, @kostajh wrote:

To clarify, the idea is that there is a components directory that is used by both the MediaWiki code (e.g. code that is in modules/ext.growthExperiments.StructuredTask.PreEdit/{SomeFiles}.vue) and in the demo directory (documentation/frontend/component-demos).

Both the MediaWiki extension code and the demo directory will need to import from the same shared component library.

The process you are describing is not possible without a build step, are you suggesting to introduce such build step within this task?

I think eventually we will need that, yes.

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 16 2023, 11:25 AM
KStoller-WMF triaged this task as Medium priority.Mar 20 2023, 2:32 AM
Sgs changed the task status from Open to In Progress.May 15 2023, 10:09 AM
Sgs moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Sgs added a comment.May 15 2023, 10:17 AM

Resolving since we are already hosting the files in separate directories components vs component-demos since 895801

Sgs closed this task as Resolved.May 15 2023, 10:17 AM
Sgs moved this task from Code Review to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL