@kostajh - the post-edit dialog doesn't display the content (the same behavior is on mobile):
For other cases - when there are more suggestions in the queue, the post-edit dialog is displayed correctly.
That is probably is fallout from the implementation of rEGREf323bd17781e: Post edit panel: do not wait for tasks request to show the panel which got merged after this task was completed. I'll make a follow-up task.
Description
Description
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | KStoller-WMF | T248330 [EPIC] Growth: Positive reinforcement | |||
| Resolved | KStoller-WMF | T317813 [EPIC] Positive Reinforcement: Leveling Up | |||
| Resolved | • KMorgan-WMF | T324177 Post edit dialog: no suggested edits | |||
| Resolved | BUG REPORT | Sgs | T331980 Post edit dialog: "No suggestions" content does not display |
Event Timeline
Comment Actions
Change 898832 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] Post edit panel: prevent skeleton from sticking when there are no results
Comment Actions
Should we try to improve the code in homepage.page.js that tries to check for this?
get postEditDialog() { return $( '.mw-ge-postEditDrawer' ); }
...
async waitForPostEditDialog() {
await this.waitForDisplayedAndClickable( this.postEditDialog );
}instead of just checking for the postEditDrawer css class to be present, could we check for the next task title? cc @kostajh
Comment Actions
Change 898832 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Post-edit panel: fix skeleton behavior when there are no results