Page MenuHomePhabricator

Post edit dialog: "No suggestions" content does not display
Closed, ResolvedPublicBUG REPORT

Description

@kostajh - the post-edit dialog doesn't display the content (the same behavior is on mobile):

Screen Shot 2023-03-13 at 2.53.51 PM.png (942×1 px, 208 KB)

For other cases - when there are more suggestions in the queue, the post-edit dialog is displayed correctly.

That is probably is fallout from the implementation of rEGREf323bd17781e: Post edit panel: do not wait for tasks request to show the panel which got merged after this task was completed. I'll make a follow-up task.

Event Timeline

kostajh created this task.
kostajh changed the subtype of this task from "Task" to "Bug Report".
Sgs changed the task status from Open to In Progress.Mar 14 2023, 6:46 PM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 898832 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Post edit panel: prevent skeleton from sticking when there are no results

https://gerrit.wikimedia.org/r/898832

Should we try to improve the code in homepage.page.js that tries to check for this?

get postEditDialog() { return $( '.mw-ge-postEditDrawer' ); }
...
async waitForPostEditDialog() {
	await this.waitForDisplayedAndClickable( this.postEditDialog );
}

instead of just checking for the postEditDrawer css class to be present, could we check for the next task title? cc @kostajh

Change 898832 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Post-edit panel: fix skeleton behavior when there are no results

https://gerrit.wikimedia.org/r/898832