Maniphest T332090

Post page tools cleanup: Remove page tools disabled code
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Mar 14 2023, 9:42 PM

Description

In T331052 we will enable page tools for anonymous users.
When that's done we should look to remove the code supporting the old experience. This will improve frontend performance by loading less CSS and JS, and be easier to maintain.

Checklist

Drop the associated feature flags from the codebase (VectorPageTools)
Remove any CSS associated with the disabled state
Remove code relating to sidebar persistence that doesn't relate to pinning feature (resources/skins.vector.js/sidebarPersistence.js). Note collapsing code should remain, renaming file might be a good idea. (see https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/893541/2/resources/skins.vector.js/sidebarCollapseResize.js)
Remove the non-functional VectorDisableSidebarPersistence configuration flag and associated code (see https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/893044)

Details

Other Assignee: bwang

Subject	Repo	Branch	Lines +/-
Remove custom checkbox-hack implementations	mediawiki/skins/Vector	master	+22 -54
Drop unused VectorPageTools feature flag	operations/mediawiki-config	master	+0 -13
Remove vector-feature-page-tools-enabled class	mediawiki/skins/Vector	master	+0 -5
Follow-up to 6e8a98ca removing checkbox.js	mediawiki/skins/Vector	master	+1 -139
Remove custom sidebar config	mediawiki/skins/Vector	master	+1 -224
Remove CSS selectors for Page Tools feature flag	mediawiki/skins/Vector	master	+59 -351
remove Page Tools config & HTML	mediawiki/skins/Vector	master	+34 -145

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	Jdlrobson	T332090 Post page tools cleanup: Remove page tools disabled code
		Resolved		Jdlrobson	T318011 Remove 'vector-sidebar-container-no-toc' class

Event Timeline

Jdlrobson created this task.Mar 14 2023, 9:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2023, 9:42 PM

Jdlrobson triaged this task as High priority.Mar 14 2023, 9:44 PM

Jdlrobson added a project: Desktop Improvements (Vector 2022).

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)Mar 14 2023, 9:46 PM

ovasileva moved this task from Incoming to Current Quarter on the Web-Team-Backlog board.Mar 15 2023, 4:39 PM

Jdlrobson mentioned this in T328340: Improve the saving of persistent settings.Mar 15 2023, 4:59 PM

LGoto set the point value for this task to 5.Mar 16 2023, 5:44 PM

Jdlrobson merged a task: T328340: Improve the saving of persistent settings.Mar 24 2023, 6:11 PM

Jdlrobson added a subscriber: Od1n.

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6); removed Web-Team-Backlog.Mar 27 2023, 3:14 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.Mar 27 2023, 5:19 PM

Jdrewniak claimed this task.Mar 27 2023, 6:10 PM

Jdrewniak moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.

bwang added a subtask: T323626: Clean up overflow tab logic.Mar 27 2023, 6:22 PM

bwang closed subtask T323626: Clean up overflow tab logic as Declined.Mar 27 2023, 6:39 PM

bwang removed a subtask: T323626: Clean up overflow tab logic.

Out of curiosity (and per @bwang's suggestion) I'm measuring the bytesize of the CSS payload before the excess code is removed.

In production, on enwiki, with page tools enabled for anonymous users, using this Gist I created previously:
https://gist.github.com/jandre3000/b3d1c297f8c661e7586eea79fe72feef

module name	size (kb)	gzip (kb)
skins.vector.styles.legacy	32.0576	7.42676
skins.vector.styles	60.6875	11.0771
skins.vector.icons.js	3.57812	0.337891
skins.vector.icons	7.40039	0.548828
skins.vector.es6	0.477539	0.477539

The skin.vector.styles module (contains Page Tools CSS) is 60kb, 11kb gzipped.

Jdlrobson added a subtask: T318011: Remove 'vector-sidebar-container-no-toc' class.Mar 28 2023, 4:00 AM

Change 903363 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [WIP] Remove CSS selectors for Page Tools feature flag

https://gerrit.wikimedia.org/r/903363

gerritbot added a project: Patch-For-Review.Mar 28 2023, 4:58 AM

Jdlrobson mentioned this in T318011: Remove 'vector-sidebar-container-no-toc' class.Mar 28 2023, 7:55 PM

Change 903849 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] remove Page Tools config & HTML

https://gerrit.wikimedia.org/r/903849

Change 904204 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Remove custom sidebar persistence handling

https://gerrit.wikimedia.org/r/904204

Jdrewniak removed Jdrewniak as the assignee of this task.Mar 29 2023, 4:52 PM

Jdrewniak moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.

Jdrewniak moved this task from Incoming to Page Tools on the Desktop Improvements (Vector 2022) board.

Jdrewniak subscribed.

bwang claimed this task.Mar 29 2023, 5:44 PM

bwang reassigned this task from bwang to Jdrewniak.Mar 29 2023, 6:02 PM

bwang moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.

Jdlrobson updated Other Assignee, added: bwang.Mar 30 2023, 3:55 PM

Change 903849 merged by jenkins-bot:

[mediawiki/skins/Vector@master] remove Page Tools config & HTML

https://gerrit.wikimedia.org/r/903849

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.3; 2023-04-03).Mar 30 2023, 6:00 PM

Change 903363 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove CSS selectors for Page Tools feature flag

https://gerrit.wikimedia.org/r/903363

Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.Mar 31 2023, 5:57 PM

Remaining work would be to remove the HTML element feature class vector-feature-page-tools-enabled and the remaining usages in CSS. Anything else?

Change 904204 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove custom sidebar config

https://gerrit.wikimedia.org/r/904204

Maintenance_bot removed a project: Patch-For-Review.Mar 31 2023, 11:30 PM

Change 905336 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Remove custom checkbox-hack implementations

https://gerrit.wikimedia.org/r/905336

gerritbot added a project: Patch-For-Review.Apr 4 2023, 3:39 AM

Change 905757 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Remove vector-feature-page-tools-enabled class

https://gerrit.wikimedia.org/r/905757

bwang reassigned this task from Jdrewniak to ovasileva.Apr 5 2023, 4:12 PM

bwang reassigned this task from ovasileva to Jdrewniak.

bwang moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.

bwang moved this task from Ready for Signoff to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.

bwang moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.

bwang added a subscriber: ovasileva.

Change 905336 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove custom checkbox-hack implementations

https://gerrit.wikimedia.org/r/905336

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.4; 2023-04-10); removed MW-1.41-notes (1.41.0-wmf.3; 2023-04-03).Apr 5 2023, 11:00 PM

Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.Apr 5 2023, 11:06 PM

Change 906140 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Follow-up to 6e8a98ca removing checkbox.js

https://gerrit.wikimedia.org/r/906140

bwang reassigned this task from Jdrewniak to ovasileva.Apr 6 2023, 2:55 PM

bwang moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.

Change 906140 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Follow-up to 6e8a98ca removing checkbox.js

https://gerrit.wikimedia.org/r/906140

Change 905757 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove vector-feature-page-tools-enabled class

https://gerrit.wikimedia.org/r/905757

Maintenance_bot removed a project: Patch-For-Review.Apr 6 2023, 3:31 PM

LGoto reassigned this task from ovasileva to Jdlrobson.Apr 10 2023, 5:13 PM

Change 907511 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Drop unused VectorPageTools feature flag

https://gerrit.wikimedia.org/r/907511

gerritbot added a project: Patch-For-Review.Apr 10 2023, 6:23 PM

While signing off I noticed configuration in https://codesearch.wmcloud.org/search/?q=VectorPageTools&files=&excludeFiles=&repos= - I'll make sure that happens.

Change 907511 merged by jenkins-bot:

[operations/mediawiki-config@master] Drop unused VectorPageTools feature flag

https://gerrit.wikimedia.org/r/907511

Mentioned in SAL (#wikimedia-operations) [2023-04-12T20:05:07Z] <zabe@deploy2002> Started scap: Backport for [[gerrit:907511|Drop unused VectorPageTools feature flag (T332090)]], [[gerrit:907539|Set Vector 2022 as default skin on Welsh Wikipedia (T334279)]]

Mentioned in SAL (#wikimedia-operations) [2023-04-12T20:06:26Z] <zabe@deploy2002> zabe and jdlrobson: Backport for [[gerrit:907511|Drop unused VectorPageTools feature flag (T332090)]], [[gerrit:907539|Set Vector 2022 as default skin on Welsh Wikipedia (T334279)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Maintenance_bot removed a project: Patch-For-Review.Apr 12 2023, 8:11 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-12T20:15:27Z] <zabe@deploy2002> Finished scap: Backport for [[gerrit:907511|Drop unused VectorPageTools feature flag (T332090)]], [[gerrit:907539|Set Vector 2022 as default skin on Welsh Wikipedia (T334279)]] (duration: 10m 19s)

Jdlrobson closed subtask T318011: Remove 'vector-sidebar-container-no-toc' class as Resolved.Sep 29 2023, 5:21 PM

Post page tools cleanup: Remove page tools disabled codeClosed, ResolvedPublic5 Estimated Story PointsBUG REPORTActions