Page MenuHomePhabricator

Special:Block does not show temporary account IPs when block target field is prefilled
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to Special:Block/*Unregistered 5
  • Leave the block target field unmodified

What happens?:
The temporary account's IPs are not shown underneath the block target input field. Example:

image.png (177×1 px, 20 KB)

What should have happened instead?:
On page load the tool should detect if a temporary account is in the input box. Currently it only does this check when changes are made to the field.

Software version (skip for WMF-hosted wikis like Wikipedia):
Latest CheckUser and core code on localhost wiki

Other information (browser name/version, screenshots, etc.):
The temporary account IPs can be loaded by adding a character and then removing said character.

Event Timeline

Dreamy_Jazz renamed this task from Special:Block does not show temporary account IPs when block target field has not been edited to Special:Block does not show temporary account IPs when block target field is prefilled.Mar 15 2023, 11:38 AM

Change 899716 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] SpecialBlock.js: Check for IP addresses if target is pre-filled

https://gerrit.wikimedia.org/r/899716

Change 899716 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SpecialBlock.js: Check for IP addresses if target is pre-filled

https://gerrit.wikimedia.org/r/899716

Testing steps
Enable revealing IP addresses for temporary accounts in preferences

  • Go to Special:Block/<temporary user>
  • Or From any page that has block link (when testing this I used Contributions page) and click on the block link, the target text input should be auto filled and the IP address(es) below it revealed.

@Tchanders & @TThoabala I entered Special:Block/*Unregistered 4 which detected the temporary account in the input box during a page load. If the following below are fine, I did not see any other issues in testing.

OS: macOS 13.2
Browser: Chrome 111, Firefox 111, Safari 16.3
Skins: Vector 2022, 2010, Minerva, MonoBook, Timeless
Other Language: DE
Environment: Local

Multiple IPs (7x) - as mention in T324602 regarding showing a max of 3 IPs

T332136_IPMasking_SpecialBlock_Link1.png (734×2 px, 271 KB)

Disabled JS

T332136_IPMasking_SpecialBlock_Link_NoJS.png (1×2 px, 429 KB)

I think this may have caused T333200 which i've added as a blocker for the train for next week (April 3rd))