Page MenuHomePhabricator
Create Task
Maniphest T332136

Special:Block does not show temporary account IPs when block target field is prefilled
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Tchanders
Authored By
Dreamy_Jazz
Mar 15 2023, 11:38 AM
Project Tags
Referenced Files
F36914795: T332136_IPMasking_SpecialBlock_Link_NoJS.png
Mar 17 2023, 12:03 AM
F36914792: T332136_IPMasking_SpecialBlock_Link1.png
Mar 17 2023, 12:03 AM
F36912588: image.png
Mar 15 2023, 11:43 AM
F36912584: image.png
Mar 15 2023, 11:38 AM
Subscribers
Aklapper
Dreamy_Jazz
GMikesell-WMF
Jdlrobson
• TThoabala

Description

Steps to replicate the issue (include links if applicable):

  • Go to Special:Block/*Unregistered 5
  • Leave the block target field unmodified

What happens?:
The temporary account's IPs are not shown underneath the block target input field. Example:

image.png (1,336×177 px, 20 KB)

What should have happened instead?:
On page load the tool should detect if a temporary account is in the input box. Currently it only does this check when changes are made to the field.

Software version (skip for WMF-hosted wikis like Wikipedia):
Latest CheckUser and core code on localhost wiki

Other information (browser name/version, screenshots, etc.):
The temporary account IPs can be loaded by adding a character and then removing said character.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
SpecialBlock.js: Check for IP addresses if target is pre-filledTchandersmediawiki/extensions/CheckUsermaster+5 -4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 Resolved• NiharikaT324492 Temporary accounts - MVP
 ResolvedNoneT340001 [Epic] Deployment plan for Temporary Accounts
 Resolved• NiharikaT348895 [Epic] Temporary accounts testwiki deployment
 ResolvedGoal• NiharikaT300294 [Epic] Temporary account block workflow
 Resolved• TThoabalaT324602 SpecialBlock: Once a temporary account is selected, below the username field display IP addresses associated with the account
 ResolvedBUG REPORTTchandersT332136 Special:Block does not show temporary account IPs when block target field is prefilled
 ResolvedDreamy_JazzT371116 Deploy temporary accounts to test2wiki
 ResolvedkostajhT378334 Temporary Accounts: Minor pilot - Oct 29, 2024 deploy
 ResolvedTchandersT378336 Temporary Accounts: Minor pilots - Nov 5, 2024 deploy
 ResolvedDreamy_JazzT379108 Enable temporary accounts on metawiki beta
 Resolved• NiharikaT396464 Temp Accounts: 17 June, 2025 deployment
 ResolvedTchandersT396465 Temp Accounts: 24 June, 2025 deployment
 ResolvedkostajhT397940 Batch 3 deployment of Temp Accounts Major pilots
 ResolvedSTranT400672 Deploy temporary accounts to special/non-standard/private wikis
 ResolvedTchandersT402181 Deploy Temporary accounts to all remaining small-sized projects
 Resolved• NiharikaT403399 Deploy Temporary accounts to all medium-sized projects
 ResolvedTchandersT405195 Deploy temporary accounts to Italian Wikipedia
 Resolved• NiharikaT409079 Deploy Temporary accounts to English Wikipedia
 ResolvedSTranT409691 Deploy Temporary accounts to Spanish, Commons, Wikidata and others
 ResolvedTchandersT411618 Deploy Temporary accounts to the two remaining former LQT wikis
 ResolvedTchandersT413771 Deploy temporary accounts to Russian Wikipedia

Event Timeline

Dreamy_Jazz created this task.Mar 15 2023, 11:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2023, 11:38 AM
Dreamy_Jazz renamed this task from Special:Block does not show temporary account IPs when block target field has not been edited to Special:Block does not show temporary account IPs when block target field is prefilled.Mar 15 2023, 11:38 AM
Dreamy_Jazz mentioned this in T324602: SpecialBlock: Once a temporary account is selected, below the username field display IP addresses associated with the account.
Dreamy_Jazz added a parent task: T324602: SpecialBlock: Once a temporary account is selected, below the username field display IP addresses associated with the account.Mar 15 2023, 11:41 AM
Dreamy_Jazz updated the task description. (Show Details)Mar 15 2023, 11:43 AM
Tchanders edited projects, added: Anti-Harassment-Team (AHaT Sprint 27: The Big Yellow Hat); removed: Anti-Harassment-Team.Mar 15 2023, 4:52 PM
Tchanders claimed this task.Mar 15 2023, 6:11 PM
gerritbot added a comment.Mar 15 2023, 6:12 PM

Change 899716 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] SpecialBlock.js: Check for IP addresses if target is pre-filled

https://gerrit.wikimedia.org/r/899716

gerritbot added a project: Patch-For-Review.Mar 15 2023, 6:13 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 27: The Big Yellow Hat) board.Mar 15 2023, 6:13 PM
• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 27: The Big Yellow Hat) board.Mar 15 2023, 7:09 PM
Dreamy_Jazz moved this task from Inbox to Temporary account IP reveal on the CheckUser board.Mar 15 2023, 7:14 PM
gerritbot added a comment.Mar 15 2023, 7:20 PM

Change 899716 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SpecialBlock.js: Check for IP addresses if target is pre-filled

https://gerrit.wikimedia.org/r/899716

• TThoabala subscribed.Mar 15 2023, 7:25 PM

Testing steps
Enable revealing IP addresses for temporary accounts in preferences

  • Go to Special:Block/<temporary user>
  • Or From any page that has block link (when testing this I used Contributions page) and click on the block link, the target text input should be auto filled and the IP address(es) below it revealed.
Maintenance_bot removed a project: Patch-For-Review.Mar 15 2023, 7:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 15 2023, 8:01 PM
GMikesell-WMF subscribed.Mar 17 2023, 12:03 AM

@Tchanders & @TThoabala I entered Special:Block/*Unregistered 4 which detected the temporary account in the input box during a page load. If the following below are fine, I did not see any other issues in testing.

OS: macOS 13.2
Browser: Chrome 111, Firefox 111, Safari 16.3
Skins: Vector 2022, 2010, Minerva, MonoBook, Timeless
Other Language: DE
Environment: Local

Multiple IPs (7x) - as mention in T324602 regarding showing a max of 3 IPs

T332136_IPMasking_SpecialBlock_Link1.png (2,246×734 px, 271 KB)

Disabled JS

T332136_IPMasking_SpecialBlock_Link_NoJS.png (2,344×1,628 px, 429 KB)

GMikesell-WMF added a comment.Mar 22 2023, 5:35 PM

@TThoabala Moving this to Done since it has the same issues mentioned in T324602: SpecialBlock: Once a temporary account is selected, below the username field display IP addresses associated with the account. Thanks!

GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q2 2022-2023 on the Anti-Harassment-Team (AHaT Sprint 27: The Big Yellow Hat) board.Mar 22 2023, 5:35 PM
Jdlrobson mentioned this in T333200: TypeError: blockTargetWidget.getValue(...).trim is not a function.Mar 27 2023, 4:54 PM
Jdlrobson subscribed.Mar 27 2023, 4:57 PM

I think this may have caused T333200 which i've added as a blocker for the train for next week (April 3rd))

Tchanders closed this task as Resolved.Apr 25 2023, 4:14 PM
Dreamy_Jazz mentioned this in T334713: Should Special:Block perform automatic lookups of IP addresses for temporary users?.May 4 2023, 5:58 PM
Dreamy_Jazz mentioned this in T335996: "Show IP" button not shown on Special:Block if form has username pre-filled.May 4 2023, 6:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits