Acceptance Criteria
- The generation of dynamic text for the campaign day sentence and the visitors vs donors sentence is ported to Vue.
Implementation Notes
- We should refactor this to an object tree or use a Builder pattern while porting.
Acceptance Criteria
Implementation Notes
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T327621 Port WMDE Fundraising Banners to Vue | |||
Resolved | None | T327628 Port Desktop DE banner | |||
Resolved | None | T332156 Port the generation of dynamic banner text to Vue | |||
Resolved | None | T332160 Port the banner progress bar to Vue |
Suggestion for resolving the campaign parameters without bundling dev, wpde and wporg resolution classes with every banner (getting rid of the old getCampaignParameters):
Example snippet of the webpack config
// webpack.config module.exports = { //... resolve: { alias: { BannerParameters: path.resolve(__dirname, 'src/util/BannerParameters/DevEnvironment.js'), }, }, };
// webpack.production.config module.exports = { //... resolve: { alias: { BannerParameters: path.resolve(__dirname, 'src/util/BannerParameters/BannerParameters.js'), }, }, };
// banner_ctrl.js // This looks like a module, but is a webpack alias import {getCampaignParameters} from 'BannerParameters';