Page MenuHomePhabricator

MonoBook: Footer is malformed
Closed, DeclinedPublic

Description

1.17

Please note the change in layout between 1.17 and 1.18 of the monobook footer. screenshots attached.


Version: unspecified
Severity: enhancement

Attached:

Screen_shot_2011-09-28_at_20.49.52.png (1,582×169 px, 53 KB)

Details

Reference
bz31219

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:56 PM
bzimport added a project: MonoBook.
bzimport set Reference to bz31219.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 9113
1.18

Attached:

Screen_shot_2011-09-28_at_20.49.47.png (1,565×152 px, 44 KB)

Hmmm... wmf may not have been using footerlinks and may have instead been using a custom skin hack that got un-done when upgraded.

  • The contact us should be added in with the SkinTemplateOutputPageBeforeExec hook by modifying $tpl->data['footerlinks'][???].
  • Wikimedia also seams to display: block; the copyright and if visible lastmod line, the monobook css should be tweaked in some wmf specific place (typically the proper place for this would be a wiki's site-css but in wmf's case this applies to all wmf wikis but no default-mw wikis so some wmf common stylesheet is the proper thing here).

Actually, this is not a regression. It seems that the English Wikipedia have made local overrides to pretty this up a bit, by adding <br> statements.

http://tr.wikipedia.org/wiki/Farrah_Fawcett?useskin=monobook on 1.17wmf1 behaves the same as the dutch 1.18 it seems.

So not a regression, but still ugly, and something that we should probably improve.

presently in my localhost I could find only three links in the footer are "private policy" , "about wiki" and "disclimars" and even there is no link for the copyright information in the footer Is this issue about adding the "contact us" link and copyright information in the monobook skin footer ?

No, this is regarding a layout issue (which we should maybe just close... ). Presence of elements in the footer is dictated on other criteria as described in https://www.mediawiki.org/wiki/Manual:Footer

This is done by a local en.wikipedia.org override:

div#footer #lastmod, div#footer #copyright {
    display: block;
}

Disabling this makes the layout match that of the MW default. This can be undone or furher modified as desired by enwiki.