Page MenuHomePhabricator

Help panel: Fix duplicate postedit-impression events
Closed, ResolvedPublic

Description

From parent task:

It seems there's another problem, though, because I see multiple impression events for the post-edit dialog after dismissing the try new task panel:

I checked event data, and it looks like this is also happening in production. Found a session where every task navigation click in the post-edit dialogue is followed by four impression events. If needed, I can dig up more information.

I don't see this as a blocker for release, though. Maybe something to dig into the days following deployment?

Hmm, it looks like it may date back to rEGREf9e68da4cb75: Suggested Edits: Add refresh button on post-edit dialog from June 2021. Or some code added then is now being triggered more often than we intended to.

Event Timeline

Change 899660 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] HelpPanel: Remove duplicate postedit-impression events

https://gerrit.wikimedia.org/r/899660

Change 899660 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] HelpPanel: Remove duplicate postedit-impression events

https://gerrit.wikimedia.org/r/899660

Etonkovidova subscribed.

I checked (testwiki wmf.2) the scenario when the leveling up post-edit dialog is dismissed via "No thanks". When the regular pos-edit dialog appears, there are no additional impression events. E.g.

User actionsHelpPanel schema events
after 5 edits the leveling up post-edit dialog appearsevent: action: "trynewtask-impression" action_data: "next-suggested-task-type=link-recommendation;savedTaskType=copyedit;edit-count-for-task-type=5" context: "postedit-trynewtask" editor_interface: "visualeditor"
a user dismisses the leveling up post-edit dialog via "No thanks"; the leveling up dialog disappears, the regular post-edit dialog appearsthree events are recorded: (1) action: "trynewtask-nothanks-action" action_data: "dont-show-again=0" context: "postedit-trynewtask" editor_interface: "visualeditor" (2) action: "trynewtask-close" action_data: "dont-show-again=0" context: "postedit-trynewtask" editor_interface: "visualeditor" (3) action: "postedit-impression" action_data: "type=full;savedTaskType=copyedit;userTaskTypes=copyedit context: "postedit" editor_interface: "visualeditor"