Page MenuHomePhabricator

Help panel: Fix duplicate postedit-impression events
Open, Needs TriagePublic


From parent task:

It seems there's another problem, though, because I see multiple impression events for the post-edit dialog after dismissing the try new task panel:

I checked event data, and it looks like this is also happening in production. Found a session where every task navigation click in the post-edit dialogue is followed by four impression events. If needed, I can dig up more information.

I don't see this as a blocker for release, though. Maybe something to dig into the days following deployment?

Hmm, it looks like it may date back to rEGREf9e68da4cb75: Suggested Edits: Add refresh button on post-edit dialog from June 2021. Or some code added then is now being triggered more often than we intended to.

Event Timeline

Change 899660 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] HelpPanel: Remove duplicate postedit-impression events

Change 899660 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] HelpPanel: Remove duplicate postedit-impression events