Page MenuHomePhabricator
Create Task
Maniphest T332234

Cannot access workboard: Unhandled Exception: Undefined variable: other_assignees
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
brennen
Authored By
• VirginiaPoundstone
Mar 15 2023, 10:14 PM
Tags
Referenced Files
F36919648: image.png
Mar 20 2023, 10:05 AM
F36919643: Screenshot_20230320_110109.png
Mar 20 2023, 10:02 AM
F36913641: IMG_8923.png
Mar 15 2023, 10:14 PM
F36913637: Screenshot 2023-03-15 at 6.05.09 PM.png
Mar 15 2023, 10:14 PM
Subscribers
Aklapper
brennen
Clement_Goubert
Dzahn
jcrespo
RhinosF1
TheresNoTime
• VirginiaPoundstone

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Error message appears:

Unhandled Exception ("runtimeException")
Undefined variable: other_assignees

What should have happened instead?:

  • I should have seen the workboard for the milestone
  • I saw the workboard previously: I was working on a workboard view of the milestone, shared the link in Slack, a team mate reported the link wasn't working for them with a screenshot of the error message, so I refreshed the page and now receive the same error message they did.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
I'm using a MacBook pro M1 Max
Chrome Version 109.0.5414.119
Team mate encountered the same error on their mobile phone.

Screenshot 2023-03-15 at 6.05.09 PM.png (397×1 px, 68 KB)

IMG_8923.png (2×1 px, 301 KB)

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
workboards: Initialize $other_assignees arrayrepos/phabricator/phabricator!2brennenwork/other-assigneeswmf/stable
Customize query in GitLab

Related Objects
Search...

Event Timeline

• VirginiaPoundstone created this task.Mar 15 2023, 10:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2023, 10:14 PM
RhinosF1 triaged this task as Unbreak Now! priority.Mar 15 2023, 10:16 PM
RhinosF1 subscribed.

Fallout of recent deployment

brennen subscribed.Mar 15 2023, 10:18 PM
RhinosF1 added a comment.Mar 15 2023, 10:18 PM

This is being investigated. Deployers are aware.

brennen added a comment.Mar 15 2023, 10:18 PM

Fallout of recent deployment

Yep, investigating. Will roll out a revert shortly if there's not an obvious immediate fix.

Dzahn subscribed.Mar 15 2023, 10:20 PM

related ticket that introduced "other assignee" field: T329974

Dzahn mentioned this in T329974: Show "other assignee" avatar on tasks in workboard.Mar 15 2023, 10:21 PM
Dzahn added a comment.Mar 15 2023, 10:29 PM
AH01071: Got error 'PHP message: [2023-03-15 22:28:58] EXCEPTION: (RuntimeException) Undefined variable: other_assignees at [<arcanist>/src/error/PhutilErrorHandler.php:235]PHP message: arcanist(), ava(), phabricator(), translations(), wmf-ext-misc()PHP message:   #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/project/controller/PhabricatorProjectBoardViewController.php:243]PHP message:   #1 <#2> PhabricatorProjectBoardViewController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:284]PHP message:   #2 phlog(RuntimeException) called at [<phabricator>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]PHP message:   #3 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, RuntimeException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]PHP message:   #4 AphrontApplicationConfiguration::handleThrowable(RuntimeException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:296]PHP message:   #5 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]PHP message:   #6 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:35]'
Dzahn added a comment.EditedMar 15 2023, 10:31 PM

@VirginiaPoundstone Workboard is back for me. @brennen reverted the recent change that introduced this "other assignee" field for now.

brennen claimed this task.Mar 15 2023, 10:33 PM

Looking at code, should be a simple fix. Reverted in production in the meanwhile.

brennen lowered the priority of this task from Unbreak Now! to Medium.Mar 15 2023, 10:33 PM
brennen added a parent task: T329974: Show "other assignee" avatar on tasks in workboard.Mar 15 2023, 10:53 PM
Aklapper renamed this task from Milestone workboard view no longer visible to Cannot access workboard: Unhandled Exception: Undefined variable: other_assignees.Mar 16 2023, 8:19 AM
jcrespo raised the priority of this task from Medium to Unbreak Now!.Mar 20 2023, 10:02 AM
jcrespo subscribed.

I found another major regression: I cannot read the task: https://phabricator.wikimedia.org/T331695

It says "Undefined index: state" in an unhandled exception, maybe triggered by the recent upgrade (and revert?).

Screenshot_20230320_110109.png (416×1 px, 24 KB)

TheresNoTime subscribed.Mar 20 2023, 10:05 AM
In T332234#8708974, @jcrespo wrote:

I found another major regression: I cannot read the task: https://phabricator.wikimedia.org/T331695

It says "Undefined index: state" in an unhandled exception, maybe triggered by the recent upgrade (and revert?).

Screenshot_20230320_110109.png (416×1 px, 24 KB)

Works for me (logged in and logged out)

image.png (504×1 px, 34 KB)

jcrespo lowered the priority of this task from Unbreak Now! to Medium.Mar 20 2023, 10:09 AM

Weird, I double checked with 2 other SREs that stated the same issue (claime and volans). No problem, then. Maybe it got cached just for a while in a bad state and after a while it got good.

Clement_Goubert subscribed.Mar 20 2023, 10:12 AM

Yeah, can confirm it now works, without having to log in or out.

brennen mentioned this in T332607: GitLab MR widget sometimes errors out on a missing index.Mar 20 2023, 4:03 PM

It says "Undefined index: state" in an unhandled exception, maybe triggered by the recent upgrade (and revert?).

This is almost certainly from recently deployed code, but a separate patch (T324149). I'll sort out the specifics under T332607: GitLab MR widget sometimes errors out on a missing index.

gerritbot added a comment.Mar 20 2023, 8:51 PM

brennen opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/2

workboards: Initialize $other_assignees array

gerritbot added a project: Patch-For-Review.Mar 20 2023, 8:51 PM
brennen changed the task status from Open to In Progress.Mar 20 2023, 10:19 PM
brennen added projects: Release-Engineering-Team, User-brennen.
brennen moved this task from Backlog to Waiting Response on the User-brennen board.
gerritbot added a comment.Mar 29 2023, 9:53 PM

brennen merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/2

workboards: Initialize $other_assignees array

Maintenance_bot removed a project: Patch-For-Review.Mar 29 2023, 10:10 PM
brennen mentioned this in T333516: Phabricator deployment 2023-03-30.Mar 30 2023, 1:12 AM
brennen closed this task as Resolved.Mar 30 2023, 3:40 PM

This is redeployed with the fix.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits