Page MenuHomePhabricator

store.addZObjects.changeType: Rewrite the changeType/addZObject functions so that they accomodate append and initialization
Closed, ResolvedPublicBUG REPORT

Description

Description

  • Old methods allow for value initialization while the new getScaffolding method doesn't
  • New method allows for append to list, while the old methods don't

Fix this so that both features work for all types (even generic)


Completion checklist

Event Timeline

Change 900452 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix changeType methods and improve related tests

https://gerrit.wikimedia.org/r/900452

Change 902145 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Replace all addZ* methods in components with their correct call to changeType

https://gerrit.wikimedia.org/r/902145

Change 900452 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix changeType methods and improve related tests

https://gerrit.wikimedia.org/r/900452

Change 902145 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Replace all addZ* methods in components with their correct call to changeType

https://gerrit.wikimedia.org/r/902145