Steps to replicate the issue (include links if applicable):
What happens?
You are redirected to the Query Service: https://query.wikidata.org/
What should have happened instead?
It should not be linked at all, as everything happens on one page and all progress could be accidentally lost.
Other information (browser name/version, screenshots, etc.)
Change 936723 had a related patch set uploaded (by Michael Große; author: Michael Große):
[wikidata/query-builder@master] Fix logo link to take base path into account
Change 936723 merged by jenkins-bot:
[wikidata/query-builder@master] Fix logo link to take base path into account
Change 936760 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder):
[wikidata/query-builder/deploy@production] Merging from 15174eb4a189431be0213dc54b47c56cecaf57ae
Change 936760 merged by Michael Große:
[wikidata/query-builder/deploy@production] Merging from 15174eb4a189431be0213dc54b47c56cecaf57ae
This should now be fixed and can be verified on https://query.wikidata.org/querybuilder/
Thanks for the changes, @Michael! I believe, though, that the Query builder logo shouldn't link anywhere: all that linking to https://query.wikidata.org/querybuilder/ does is reloading the page, which could be problematic given that all progress would be lost if the link is activated by mistake. What do you think @Arian_Bozorg?
Yes, sure that makes a lot of sense.
Do you mind removing the link @Michael?
I'll update the ticket :)
Sure, I'm able to that quickly.
But are you really sure that this is a good idea? Having the logo link back to the main page in an initial state is very common pattern, basically everywhere. Useful both for opening new tabs of the Query Builder (middle click) or resetting the current view.
It is true for all sorts of other projects that we have, like mismatch finder, the codex documentation, or the Wikipedia Main Page, and basically everywhere else on the web.
That's right. But what all those platforms have in common is that they consist of multiple pages, and their logo offers a common shortcut to main. The justification to remove the link was that this navigation function is not needed in the Query builder. I also thought that resetting the current view could be an unwanted consequence here, as we cannot know if this would match the users' expectations. (Plus, the reload browser button is also available if that's what they aim for.)
Nevertheless, after exploring a bit more, I'd say we can keep the link: this is what the Query Service does, so that might answer the question about users' expectations. I also wasn't sure about removing the ability to open the QB in new tabs from users, which is a good point. All in all, I believe the link can stay.