14:03 <jgleeson> ok I guess we could fix this two ways
14:04 <jgleeson> we could update the calling code in the civi extension to send in the expected date format of a string 
14:05 <jgleeson> or we could update both the civi extension to send over the date param verbatim as a timestamp, and smashpig to expect a timestamp
14:06 --> mbeattie (~mbeattie@c-71-192-33-82.hsd1.ma.comcast.net) has joined #wikimedia-fundraising
14:08 <jgleeson> hmm I might go with option one even though it's ugly. the latter would require a smashpig verson bump and an update to civi to pull in the library updates alongside the new date param so I'll defer that for now and add a ticket to follow on with the more complete fix

protected function startRecurringPaymentAndReturnStatus(
  IRecurringPaymentProfileProvider $provider
): string {
  $profileResult = $provider->createRecurringPaymentsProfile([
    'gateway_session_id' => $this->message['gateway_session_id'],
    'description' => \Civi::settings()->get('wmf_resolved_charge_descriptor'),
    'order_id' => $this->message['order_id'],
    'amount' => $this->message['gross'],
    'currency' => $this->message['currency'],
    'email' => $this->message['email'],
    'date' => date('Y-m-d H:i:s', $this->message['date']), <<<---
  ]);
  return $profileResult->getStatus();
}

public function createRecurringPaymentsProfile( array $params ) {
	$requestParams = [
		'METHOD' => 'CreateRecurringPaymentsProfile',
		// A timestamped token, the value of which was returned in the response to the first call to SetExpressCheckout or SetCustomerBillingAgreement response.
		// Tokens expire after approximately 3 hours.
		'TOKEN' => $params['gateway_session_id'],
		'PROFILESTARTDATE' => gmdate( "Y-m-d\TH:i:s\Z", strtotime( $params['date'] ) ), <<<---
		'DESC' => $params['description'],
		'PROFILEREFERENCE' => $params['order_id'],
		'BILLINGPERIOD' => 'Month',
		'BILLINGFREQUENCY' => 1,
		'AMT' => $params['amount'],
		'CURRENCYCODE' => $params['currency'],
		'EMAIL' => $params['email'],
		'AUTOBILLOUTAMT' => 'NoAutoBill', // PayPal does not automatically bill the outstanding balance if payments fail.
		'TOTALBILLINGCYCLES' => 0, // Forever.
		'MAXFAILEDPAYMENTS' => 0, // Just keep trying
	];

	return $this->makeApiCall( $requestParams );
}