From Client::complete():
$data = $this->makeOAuthCall( $requestToken, $tokenUrl ); $return = $this->decodeJson( $data ); $accessToken = new Token( $return->key, $return->secret );
The case when the response is valid JSON but doesn't contain the expected keys isn't handled nicely. Apparently this can happen.
Change 900747 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):
[mediawiki/oauthclient-php@master] Client: check for expected values in token return
Change 900747 merged by jenkins-bot:
[mediawiki/oauthclient-php@master] Client: check for expected values in token return
Okay, apparently this happens on (some?) errors, in which case the expected keys are error (code) and message. We should be handling that more nicely.
Change 901323 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):
[mediawiki/oauthclient-php@master] [WIP] Log errors returned by server in nicer format
Change 901330 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):
[mediawiki/vagrant@master] oauth: Expose oauthclient-php demo to web
Change 901330 merged by jenkins-bot:
[mediawiki/vagrant@master] oauth: Expose oauthclient-php demo to web
Change 901323 merged by jenkins-bot:
[mediawiki/oauthclient-php@master] Log errors returned by server in nicer format