Page MenuHomePhabricator
Create Task
Maniphest T332432

Update DiscussionTools for IP masking
Closed, ResolvedPublic
Actions

Description

Required changes identified in the review on T327570:

We should also probably make these changes suggested in Tim's initial review for VisualEditor on T307056:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make topic subscriptions unavailable to temp usersmediawiki/extensions/DiscussionToolsmaster+19 -12
Update warning about logged-out editing for temp user creationmediawiki/extensions/DiscussionToolsmaster+23 -4
Don't show a link to change their preferences to temp usersmediawiki/extensions/DiscussionToolsmaster+1 -1
Update talk_page_edit logging for IP maskingmediawiki/extensions/DiscussionToolsmaster+5 -3
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 ResolvedNiharikaT324492 Temporary accounts - MVP
 OpenNoneT326816 [Epic] Update features for temporary accounts
 ResolvedppelbergT326876 Update Editing Team-owned products that may be affected by temporary users
 ResolvedmatmarexT332432 Update DiscussionTools for IP masking
 ResolvedmatmarexT332437 Change EditAttemptStep and other schemas and logging to support temp users
 ResolvedmatmarexT332438 Centralize EditAttemptStep logging code in WikimediaEvents
 ResolvedmatmarexT330338 [SPIKE] Determine what – if any – changes need to be made to editing-related schemas to handle temporary accounts
 ResolvedmatmarexT335532 Expose IP masking (temporary user creation) configuration in the API
 ResolvedmatmarexT335590 New messages are needed for empty state of temporary user talk pages
 ResolvedmatmarexT335530 New messages are needed for warnings about logged-out editing for IP masking
 ResolvedmatmarexT337784 Prevent DiscussionTools from setting preferences for temporary accounts
 ResolvedmatmarexT338002 Let action=edit API instruct the client to redirect to another location after saving the edit
 ResolvedmatmarexT338003 Expose a method to display post-edit notification after reloading the page
 ResolvedBUG REPORTmatmarexT331397 Live preview returns IP address as signature
 ResolvedmatmarexT344879 Show the "Temporary user" popup with the post-edit notification if needed

Event Timeline

matmarex created this task.Mar 17 2023, 6:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2023, 6:56 PM
matmarex added a parent task: T326876: Update Editing Team-owned products that may be affected by temporary users.Mar 17 2023, 6:59 PM
matmarex mentioned this in T327570: [SPIKE] Document the changes IP Masking will require the Editing Team to make.
matmarex added a subtask: T332437: Change EditAttemptStep and other schemas and logging to support temp users.Mar 17 2023, 7:09 PM
ppelberg added a project: Editing-team.Mar 23 2023, 3:08 PM
ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.
ppelberg added a project: Temporary accounts.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
gerritbot added a comment.Apr 11 2023, 7:52 PM

Change 907969 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Update talk_page_edit logging for IP masking

https://gerrit.wikimedia.org/r/907969

gerritbot added a project: Patch-For-Review.Apr 11 2023, 7:52 PM
matmarex updated the task description. (Show Details)Apr 11 2023, 8:21 PM
gerritbot added a comment.Apr 14 2023, 4:26 PM

Change 907969 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Update talk_page_edit logging for IP masking

https://gerrit.wikimedia.org/r/907969

Maintenance_bot removed a project: Patch-For-Review.Apr 14 2023, 4:29 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 14 2023, 5:00 PM
matmarex closed subtask T332437: Change EditAttemptStep and other schemas and logging to support temp users as Resolved.Apr 18 2023, 7:31 PM
matmarex mentioned this in T335530: New messages are needed for warnings about logged-out editing for IP masking.Apr 27 2023, 7:17 PM
gerritbot added a comment.Apr 27 2023, 11:45 PM

Change 912999 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Update warning about logged-out editing for temp user creation

https://gerrit.wikimedia.org/r/912999

gerritbot added a project: Patch-For-Review.Apr 27 2023, 11:45 PM
matmarex claimed this task.Apr 27 2023, 11:51 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.
matmarex moved this task from Inbox to Doing on the Editing-team (Kanban Board) board.
matmarex added a subtask: T335532: Expose IP masking (temporary user creation) configuration in the API.Apr 28 2023, 1:56 AM
matmarex updated the task description. (Show Details)
matmarex updated the task description. (Show Details)Apr 28 2023, 3:40 PM
gerritbot added a comment.Apr 28 2023, 3:42 PM

Change 913226 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Don't show a link to change their preferences to temp users

https://gerrit.wikimedia.org/r/913226

matmarex added a subtask: T335590: New messages are needed for empty state of temporary user talk pages.Apr 28 2023, 3:42 PM
matmarex updated the task description. (Show Details)
matmarex added a subtask: T335530: New messages are needed for warnings about logged-out editing for IP masking.Apr 28 2023, 6:25 PM
matmarex updated the task description. (Show Details)Apr 28 2023, 6:27 PM
matmarex closed subtask T335532: Expose IP masking (temporary user creation) configuration in the API as Resolved.May 2 2023, 8:28 PM
gerritbot added a comment.May 16 2023, 3:34 PM

Change 913226 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Don't show a link to change their preferences to temp users

https://gerrit.wikimedia.org/r/913226

gerritbot added a comment.May 16 2023, 5:51 PM

Change 912999 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Update warning about logged-out editing for temp user creation

https://gerrit.wikimedia.org/r/912999

Maintenance_bot removed a project: Patch-For-Review.May 16 2023, 6:10 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.10; 2023-05-23); removed MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).May 16 2023, 11:01 PM
matmarex added a subtask: T337784: Prevent DiscussionTools from setting preferences for temporary accounts.May 31 2023, 11:18 PM
matmarex mentioned this in T337784: Prevent DiscussionTools from setting preferences for temporary accounts.May 31 2023, 11:23 PM
matmarex added subtasks: T338002: Let action=edit API instruct the client to redirect to another location after saving the edit, T338003: Expose a method to display post-edit notification after reloading the page.Jun 2 2023, 12:01 AM
gerritbot added a comment.Jun 2 2023, 7:14 PM

Change 926608 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Make topic subscriptions unavailable to temp users

https://gerrit.wikimedia.org/r/926608

gerritbot added a project: Patch-For-Review.Jun 2 2023, 7:14 PM
matmarex updated the task description. (Show Details)Jun 2 2023, 7:16 PM
• AGueyte closed subtask T337784: Prevent DiscussionTools from setting preferences for temporary accounts as Resolved.Jun 5 2023, 2:47 PM
matmarex closed subtask T335530: New messages are needed for warnings about logged-out editing for IP masking as Resolved.Jun 5 2023, 5:34 PM
matmarex closed subtask T335590: New messages are needed for empty state of temporary user talk pages as Resolved.
gerritbot added a comment.Jun 15 2023, 4:33 PM

Change 926608 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Make topic subscriptions unavailable to temp users

https://gerrit.wikimedia.org/r/926608

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).Jun 15 2023, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 15 2023, 5:10 PM
ppelberg closed subtask T338003: Expose a method to display post-edit notification after reloading the page as Resolved.Jul 7 2023, 11:33 PM
matmarex added a subtask: T331397: Live preview returns IP address as signature.Jul 10 2023, 10:43 PM
ppelberg attached a referenced file: F34933175: image.png. (Show Details)Aug 1 2023, 4:39 PM
matmarex updated the task description. (Show Details)Aug 1 2023, 6:13 PM
ppelberg mentioned this in T344468: QA Editing-related IP Masking changes.Aug 17 2023, 10:23 PM
ppelberg closed subtask T338002: Let action=edit API instruct the client to redirect to another location after saving the edit as Resolved.
KStoller-WMF mentioned this in T342831: Temporary Accounts: Update StructuredDiscussions (Flow).Aug 21 2023, 5:09 PM
ppelberg added a project: Goal.Aug 22 2023, 7:48 PM
matmarex added a subtask: T344879: Show the "Temporary user" popup with the post-edit notification if needed.Aug 24 2023, 2:20 AM
matmarex moved this task from Doing to Ready for Sign Off on the Editing-team (Kanban Board) board.Aug 30 2023, 2:43 PM
matmarex added a project: Skipped QA.Sep 9 2023, 11:53 PM
ppelberg closed subtask T344879: Show the "Temporary user" popup with the post-edit notification if needed as Resolved.Sep 15 2023, 5:40 AM
Ryasmeen edited projects, added Verified; removed Skipped QA.Nov 8 2023, 2:50 AM
VPuffetMichel closed this task as Resolved.Dec 4 2023, 6:57 PM
VPuffetMichel closed subtask T331397: Live preview returns IP address as signature as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits