Page MenuHomePhabricator

Update WikiEditor for IP masking
Closed, ResolvedPublic

Event Timeline

Change 907970 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/WikiEditor@master] Update EditAttemptStep and VisualEditorFeatureUse for IP masking

https://gerrit.wikimedia.org/r/907970

Change 907970 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Update EditAttemptStep and VisualEditorFeatureUse for IP masking

https://gerrit.wikimedia.org/r/907970

Both EditAttemptStep and VisualEditorFeatureUse has user_is_temp field. It's set to false for both logged in and anon users and it's set to true for temp users.

@matmarex: I didn't however see VisualEditorFeatureUse being triggered for temp users for WikiEditor.

@matmarex: I didn't however see VisualEditorFeatureUse being triggered for temp users for WikiEditor.

Most of the VisualEditorFeatureUse logging in WikiEditor happens server-side, so it can't be observed in the user's browser.

However, I just found that some new logging has been added for the Realtime Preview feature, and you can see the new field there. Testing on https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Test&action=edit&trackdebug=1:

image.png (2×3 px, 766 KB)

@matmarex :True. I just checked the logging of VisualEditorFeatureUse for the Realtime Preview. It's set to false for both logged in and anon users and it's set to true for temp users for WikiEditor.