Required changes identified in the review on T327570:
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Update EditAttemptStep and VisualEditorFeatureUse for IP masking | Bartosz Dziewoński | mediawiki/extensions/WikiEditor | master | +2 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Restricted Task | |||||
| Resolved | kostajh | T294511 2021 Security Team wikireplicas audit | |||
| Declined | None | T284948 Raw IPs of logged-out users disclosed in wiki-replicas | |||
| Resolved | • Niharika | T324492 Temporary accounts - MVP | |||
| Resolved | Madalina | T326816 [Epic] Update features for temporary accounts | |||
| Resolved | ppelberg | T326876 Update Editing Team-owned products that may be affected by temporary users | |||
| Resolved | matmarex | T332436 Update WikiEditor for IP masking | |||
| Resolved | matmarex | T332437 Change EditAttemptStep and other schemas and logging to support temp users | |||
| Resolved | matmarex | T332438 Centralize EditAttemptStep logging code in WikimediaEvents | |||
| Resolved | matmarex | T330338 [SPIKE] Determine what – if any – changes need to be made to editing-related schemas to handle temporary accounts |
Event Timeline
Comment Actions
Change 907970 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/WikiEditor@master] Update EditAttemptStep and VisualEditorFeatureUse for IP masking
Comment Actions
Change 907970 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Update EditAttemptStep and VisualEditorFeatureUse for IP masking
Comment Actions
Both EditAttemptStep and VisualEditorFeatureUse has user_is_temp field. It's set to false for both logged in and anon users and it's set to true for temp users.
Comment Actions
@matmarex: I didn't however see VisualEditorFeatureUse being triggered for temp users for WikiEditor.
Comment Actions
Most of the VisualEditorFeatureUse logging in WikiEditor happens server-side, so it can't be observed in the user's browser.
However, I just found that some new logging has been added for the Realtime Preview feature, and you can see the new field there. Testing on https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Test&action=edit&trackdebug=1:
Comment Actions
@matmarex :True. I just checked the logging of VisualEditorFeatureUse for the Realtime Preview. It's set to false for both logged in and anon users and it's set to true for temp users for WikiEditor.