Page MenuHomePhabricator

LQT should escape thread titles before providing a link to the user
Closed, ResolvedPublic

Description

When the page
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Thread:Talk:Article_feedback/Bug%3F
showed up in [[mw:Special:NewMessages]] I wanted to get a link for it and clicked on "Link to". The first link provided is wrong, because it points to

https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Thread:Talk:Article_feedback/Bug?

which opens another thread (since the "?" is not escaped as it should).

I'm tagging this with the "javascript" keyword because the link provided when I disable JavaScript is correct.


Version: unspecified
Severity: normal
Whiteboard: gci2013
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47885

Details

Reference
bz31244

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:48 PM
bzimport set Reference to bz31244.
bzimport added a subscriber: Unknown Object (MLST).
He7d3r created this task.Sep 29 2011, 12:13 PM

Valerie.m.juarez wrote:

Hi Helder! Sorry that nobody has taken a look at this report yet and given feedback. I can confirm that this report is still valid.

No problem.

I'm adding keyword "easy", since escaping things shouldn't be hard to do...

  • Bug 32391 has been marked as a duplicate of this bug. ***

Change 110101 had a related patch set uploaded by Alex Monk:
Use mw.util.getUrl for generating Link URLs

https://gerrit.wikimedia.org/r/110101

Change 110101 merged by jenkins-bot:
Use mw.util.getUrl for generating Link URLs

https://gerrit.wikimedia.org/r/110101