Page MenuHomePhabricator
Create Task
Maniphest T332448

Create feature flag for Zebra#9 design update
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Create a feature flag that will enable/disable the upcoming design: https://di-content-separation.web.app/Moss

This feature flag will add a class on the html element that will enable & disable the new design.
Until someone comes up with a better name, we can call this feature VectorZebraDesign.

Acceptance criteria

  • Set up a feature flag for the new design. It should be false by default.
  • When the feature flag is enabled, the class vector-feature-zebra-design should be added to the <html> tag.
  • A query string param is available to override the feature flag

QA steps

Navigate to a page on beta cluster with the query parameter &vectorzebradesign=1 i.e. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?vectorzebradesign=1
Inspect the <html> tag in dev tools and note that the class vector-feature-zebra-design-enabled`.

QA Results - Beta

ACStatusDetails
1✅T332448#8748139

QA Results - Prod

ACStatusDetails
1✅T332448#8769880

Details

Other Assignee
Mabualruz
SubjectRepoBranchLines +/-
VectorZebraDesign configuration logged_in and logged_out keysmediawiki/skins/Vectormaster+4 -1
Create feature flag for Zebra#9 design updatemediawiki/skins/Vectormaster+39 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedovasilevaT333180 [EPIC] A/B test Zebra #9 prototype
 ResolvedNoneT332448 Create feature flag for Zebra#9 design update

Event Timeline

Jdrewniak created this task.Mar 17 2023, 8:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2023, 8:00 PM
Jdrewniak mentioned this in T331320: [SPIKE] Evaluate development of Zebra #9 prototype.Mar 20 2023, 2:35 PM
ovasileva triaged this task as High priority.Mar 21 2023, 3:48 PM
ovasileva moved this task from Incoming to Current Quarter on the Web-Team-Backlog board.
LGoto set the point value for this task to 1.Mar 23 2023, 5:19 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6); removed Web-Team-Backlog.Mar 27 2023, 3:10 PM
ovasileva added a parent task: T333180: [EPIC] A/B test Zebra #9 prototype.Mar 27 2023, 3:26 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.Mar 27 2023, 5:19 PM
Izno subscribed.Mar 27 2023, 6:21 PM
Mabualruz claimed this task.Mar 27 2023, 9:09 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.Mar 28 2023, 4:07 AM
gerritbot added a comment.Mar 28 2023, 12:38 PM

Change 903640 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Create feature flag for Zebra#9 design update

https://gerrit.wikimedia.org/r/903640

gerritbot added a project: Patch-For-Review.Mar 28 2023, 12:38 PM
Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.Mar 28 2023, 12:39 PM
Jdlrobson reassigned this task from Mabualruz to Edtadros.Mar 28 2023, 8:50 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Mabualruz.
gerritbot added a comment.Mar 28 2023, 9:09 PM

Change 903640 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Create feature flag for Zebra#9 design update

https://gerrit.wikimedia.org/r/903640

Maintenance_bot removed a project: Patch-For-Review.Mar 28 2023, 9:10 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.3; 2023-04-03).Mar 28 2023, 10:00 PM
Jdlrobson moved this task from QA to Needs More Work on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.Mar 29 2023, 8:33 PM
Jdlrobson subscribed.

@Mabualruz can we update the default value of the new VectorZebraDesign configuration to use the same format as VectorStickyHeader with logged_in and logged_out keys? We'll need to be able to define these in production.

gerritbot added a comment.Mar 30 2023, 11:28 AM

Change 904263 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] VectorZebraDesign configuration logged_in and logged_out keys

https://gerrit.wikimedia.org/r/904263

gerritbot added a project: Patch-For-Review.Mar 30 2023, 11:28 AM
Jdlrobson updated Other Assignee, added: Mabualruz.Mar 30 2023, 3:55 PM
Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.
gerritbot added a comment.Mar 30 2023, 4:19 PM

Change 904263 merged by jenkins-bot:

[mediawiki/skins/Vector@master] VectorZebraDesign configuration logged_in and logged_out keys

https://gerrit.wikimedia.org/r/904263

Maintenance_bot removed a project: Patch-For-Review.Mar 30 2023, 4:30 PM
Edtadros reassigned this task from Edtadros to ovasileva.Apr 1 2023, 11:13 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Navigate to a page on beta cluster with the query parameter &vectorzebradesign=1 i.e. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?vectorzebradesign=1
✅ AC1: Inspect the <html> tag in dev tools and note that the class vector-feature-zebra-design-enabled`.

Screenshot 2023-04-01 at 4.11.57 PM.png (1×1 px, 343 KB)

ovasileva moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.Apr 3 2023, 3:41 PM
ovasileva reassigned this task from ovasileva to Edtadros.Apr 3 2023, 3:45 PM
ovasileva moved this task from QA in Production to Ready for Signoff on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.
ovasileva moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.
ovasileva subscribed.
Edtadros closed this task as Resolved.Apr 11 2023, 2:31 AM
Edtadros removed Edtadros as the assignee of this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Navigate to a page with the query parameter &vectorzebradesign=1 i.e. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?vectorzebradesign=1
✅ AC1: Inspect the <html> tag in dev tools and note that the class vector-feature-zebra-design-enabled`.

Screenshot 2023-04-10 at 7.30.52 PM.png (1×878 px, 260 KB)

Edtadros updated the task description. (Show Details)Apr 11 2023, 2:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL