Page MenuHomePhabricator
Create Task
Maniphest T332463

SectionDisqus extension has typo in hook name
Closed, ResolvedPublic
Actions

Description

https://github.com/wikimedia/mediawiki-extensions-SectionDisqus/blob/master/extension.json#L35 refers to the SkinEditSectionLink hook. The correct name of the hook is SkinEditSectionLinks (plural).

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/SectionDisqusREL1_40+21 -9Fix main hook
mediawiki/extensions/SectionDisqusREL1_39+21 -9Fix main hook
mediawiki/extensions/SectionDisqusmaster+21 -9Fix main hook
Customize query in gerrit

Event Timeline

Pppery created this task.Sat, Mar 18, 1:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Mar 18, 1:34 AM
Kizule claimed this task.EditedSat, Mar 18, 1:46 PM
Kizule added a subscriber: Kizule.

Looks like I made that mistake in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SectionDisqus/+/748086, I'll make a patch.

Restricted Application added a project: User-Kizule. · View Herald TranscriptSat, Mar 18, 1:46 PM
gerritbot added a comment.Sat, Mar 18, 1:50 PM

Change 900710 had a related patch set uploaded (by Zoranzoki21; author: Zoranzoki21):

[mediawiki/extensions/SectionDisqus@master] Fix typo in hook name

https://gerrit.wikimedia.org/r/900710

gerritbot added a project: Patch-For-Review.Sat, Mar 18, 1:50 PM
Kizule added a parent task: T201491: Fix common typos in code.Sat, Mar 18, 1:51 PM
Kizule moved this task from Inbox to To deploy on the User-Kizule board.
Kizule added a project: good first task.Sat, Mar 18, 1:57 PM
Aklapper removed a parent task: T201491: Fix common typos in code.Sat, Mar 18, 5:47 PM
gerritbot added a comment.Sun, Mar 19, 12:39 PM

Change 900710 merged by jenkins-bot:

[mediawiki/extensions/SectionDisqus@master] Fix main hook

https://gerrit.wikimedia.org/r/900710

Maintenance_bot removed a project: Patch-For-Review.Sun, Mar 19, 1:10 PM
Kizule closed this task as Resolved.Sun, Mar 19, 1:18 PM
Kizule reassigned this task from Kizule to Sophivorus.
Kizule removed a project: User-Kizule.
gerritbot added a comment.Sun, Mar 19, 1:42 PM

Change 900681 had a related patch set uploaded (by Zoranzoki21; author: Zoranzoki21):

[mediawiki/extensions/SectionDisqus@REL1_40] Fix main hook

https://gerrit.wikimedia.org/r/900681

gerritbot added a project: Patch-For-Review.Sun, Mar 19, 1:42 PM

Change 900682 had a related patch set uploaded (by Zoranzoki21; author: Zoranzoki21):

[mediawiki/extensions/SectionDisqus@REL1_39] Fix main hook

https://gerrit.wikimedia.org/r/900682

Pppery removed a subscriber: Pppery.Sun, Mar 19, 2:30 PM
gerritbot added a comment.Sun, Mar 19, 3:25 PM

Change 900682 merged by jenkins-bot:

[mediawiki/extensions/SectionDisqus@REL1_39] Fix main hook

https://gerrit.wikimedia.org/r/900682

gerritbot added a comment.Sun, Mar 19, 3:25 PM

Change 900681 merged by jenkins-bot:

[mediawiki/extensions/SectionDisqus@REL1_40] Fix main hook

https://gerrit.wikimedia.org/r/900681

Maintenance_bot removed a project: Patch-For-Review.Sun, Mar 19, 3:30 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL