Page MenuHomePhabricator

Reimplement: disable display of language variants in variant menu without using CSS custmization
Open, Needs TriagePublic

Event Timeline

Enabled but not displayed in the menu? Why tagged Regression, I don't think this has ever been implemented.

This was implemented by setting variantname-* system messages to "disable", which was the reason of T282520: Fix unnecessary "disable" variants from the Kazakh Wikipedia on mobile web (and the deleted "disable" system messages on Fandom wikis, which was using MediaWiki 1.19).

Which code change removed the support? According to T255350#6863215, they use site JS to hide them, so it seems was not supported by the MW core.

Oh, I see, thanks. I would say at that time they just removed a broken feature, so let's not call this a regression.

For a new implementation, I think there should be two criteria:

  • We should be able to retrieve the full list of variants with their correct name from the API - so we should not rely on changing messages.
  • Individual users should be able to unhide the hidden variants, since they are not disabled and sometimes useful for debugging conversion rules - so they should not be skipped like 1.19 did.

The variants we want to hide in the variant menu are very likely to be identical to the ones we want to hide in the sitemap, so they may share a new config.

Func renamed this task from Regression: Provide functionality to disable display of language variants in variant menu without using CSS custmization to Reimplement: disable display of language variants in variant menu without using CSS custmization.Feb 18 2024, 8:17 AM