The tests expose multiple deprecation warnings that would get in the way in the future. Cleaning them up seems like a good first step for Python 3 improvements and a good first task for onboarding.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove code for supporting old Debian (<= 9.0) | operations/software/thumbor-plugins | master | +4 -21 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T313015 Investigate improvements that appear in Python 3+ | |||
| Resolved | Raine | T332548 Fix deprecation warnings |
Event Timeline
Comment Actions
Hi @kamila, thanks for taking the time to report this and welcome to Wikimedia Phabricator!
Could you please share these multiple deprecation warnings in this task?
Comment Actions
Hi @Aklapper , so far I have only found (and addressed) the DeprecationWarning: dist() and linux_distribution() functions are deprecated in Python 3.5 warning. Currently working on getting familiar with Thumbor so I can find more of them in the logs, if any. I hope to have the patch ready sometime tomorrow.
Just to provide some context: I am a new SRE in the Platform team (started last week) and me and @hnowlan agreed to do this as an onboarding task for me :-)
Edit: @Aklapper Ahoj ze Slovenska ("čtyři piva přosim!") :-)
Comment Actions
Change 902321 had a related patch set uploaded (by Kamila Součková; author: Kamila Součková):
[operations/software/thumbor-plugins@master] tests: fix usage of deprecated `platform.linux_distribution()`
Comment Actions
Change 902321 merged by jenkins-bot:
[operations/software/thumbor-plugins@master] Remove code for supporting old Debian (<= 9.0)
Comment Actions
I don't see any other obvious deprecation warnings in our code (there are some in the dependencies, but I'm not brave enough to update those right now :D). @hnowlan can we close this?