Page MenuHomePhabricator
Create Task
Maniphest T332575

Chore: Update dependencies in Query Builder
Closed, ResolvedPublic
Actions

Description

Update dependencies in Query Builder.

In the README you can find guidelines on how to update the dependencies.

If there are any issues, create a subtask.

If there are open Addbot patches then either comment recheck and +2 them, or abandon them, or create a task if they need more work. (The dependabot pull requests that trigger the Addbot patches can usually be ignored. dependabot will close them eventually.)

Details

SubjectRepoBranchLines +/-
Apply `npm audit fix`wikidata/query-buildermaster+6 -6
Update eslint-related dependencieswikidata/query-buildermaster+215 -528
Make LibUp work by being flexible with Cypress browserwikidata/query-buildermaster+13 -1
Update to TypeScript 5wikidata/query-buildermaster+9 -9
Update Cypress-related dependencieswikidata/query-buildermaster+18 -18
Update scss related dependencieswikidata/query-buildermaster+310 -166
Update jest-related dependencieswikidata/query-buildermaster+774 -857
Update netlify dependencywikidata/query-buildermaster+8 K -6 K
Customize query in gerrit

Related Objects

Event Timeline

Michael created this task.Mar 20 2023, 12:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2023, 12:51 PM
Maintenance_bot moved this task from Inbox to Sorted Team A on the [DEPRECATED] wdwb-tech board.Mar 20 2023, 1:15 PM
ItamarWMDE moved this task from Incoming to [DOT] Tech Backlog on the Wikidata Dev Team board.Mar 20 2023, 8:45 PM
karapayneWMDE moved this task from [DOT] Tech Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Mar 21 2023, 10:49 AM
karapayneWMDE subscribed.

Deployment is blocked until the language selector on query builder is released

Michael claimed this task.Mar 22 2023, 11:22 AM
Michael moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.
Michael edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
Michael moved this task from Parents/Waiting to Doing on the Wikidata Dev Team (Sprint-∞) board.
Restricted Application added a project: User-Michael. · View Herald TranscriptMar 22 2023, 11:22 AM
Michael mentioned this in T332770: [Query Builder] Use prettier instead of stylelint for stylistic rules like whitespace.Mar 22 2023, 12:09 PM
gerritbot added a comment.Mar 22 2023, 12:14 PM

Change 902069 had a related patch set uploaded (by Michael Große; author: Michael Große):

[wikidata/query-builder@master] Update eslint-related dependencies

https://gerrit.wikimedia.org/r/902069

gerritbot added a project: Patch-For-Review.Mar 22 2023, 12:14 PM

Change 902070 had a related patch set uploaded (by Michael Große; author: Michael Große):

[wikidata/query-builder@master] Update jest-related dependencies

https://gerrit.wikimedia.org/r/902070

gerritbot added a comment.Mar 22 2023, 12:14 PM

Change 902072 had a related patch set uploaded (by Michael Große; author: Michael Große):

[wikidata/query-builder@master] Update scss related dependencies

https://gerrit.wikimedia.org/r/902072

gerritbot added a comment.Mar 22 2023, 12:14 PM

Change 902073 had a related patch set uploaded (by Michael Große; author: Michael Große):

[wikidata/query-builder@master] Update netlify dependency

https://gerrit.wikimedia.org/r/902073

gerritbot added a comment.Mar 22 2023, 12:54 PM

Change 902073 abandoned by Michael Große:

[wikidata/query-builder@master] Update netlify dependency

Reason:

The EBADPLATFORM bug is still not fixed, see https://github.com/netlify/cli/issues/5323, but hopefully it will be soon: https://github.com/netlify/cli/pull/5547

https://gerrit.wikimedia.org/r/902073

gerritbot added a comment.Mar 22 2023, 1:52 PM

Change 902091 had a related patch set uploaded (by Michael Große; author: Michael Große):

[wikidata/query-builder@master] Update Cypress-related dependencies

https://gerrit.wikimedia.org/r/902091

gerritbot added a comment.Mar 22 2023, 2:02 PM

Change 902093 had a related patch set uploaded (by Michael Große; author: Michael Große):

[wikidata/query-builder@master] Update to TypeScript 5

https://gerrit.wikimedia.org/r/902093

gerritbot added a comment.Mar 23 2023, 10:44 AM

Change 902130 had a related patch set uploaded (by Michael Große; author: Michael Große):

[wikidata/query-builder@master] Make LibUp work by being flexible with Cypress browser

https://gerrit.wikimedia.org/r/902130

Michael added a comment.Mar 23 2023, 10:47 AM

This will also need another update to @wmde/eslint-config-wikimedia-typescript: https://github.com/wmde/eslint-config-wikimedia-typescript/pull/19

gerritbot added a comment.Mar 23 2023, 11:19 AM

Change 902070 merged by jenkins-bot:

[wikidata/query-builder@master] Update jest-related dependencies

https://gerrit.wikimedia.org/r/902070

gerritbot added a comment.Mar 23 2023, 11:19 AM

Change 902072 merged by jenkins-bot:

[wikidata/query-builder@master] Update scss related dependencies

https://gerrit.wikimedia.org/r/902072

gerritbot added a comment.Mar 23 2023, 11:22 AM

Change 902091 merged by jenkins-bot:

[wikidata/query-builder@master] Update Cypress-related dependencies

https://gerrit.wikimedia.org/r/902091

gerritbot added a comment.Mar 23 2023, 11:22 AM

Change 902093 merged by jenkins-bot:

[wikidata/query-builder@master] Update to TypeScript 5

https://gerrit.wikimedia.org/r/902093

gerritbot added a comment.Mar 23 2023, 3:55 PM

Change 902130 merged by jenkins-bot:

[wikidata/query-builder@master] Make LibUp work by being flexible with Cypress browser

https://gerrit.wikimedia.org/r/902130

gerritbot added a comment.Mar 23 2023, 3:55 PM

Change 902069 merged by jenkins-bot:

[wikidata/query-builder@master] Update eslint-related dependencies

https://gerrit.wikimedia.org/r/902069

gerritbot added a comment.Mar 24 2023, 7:36 AM

Change 902421 had a related patch set uploaded (by Michael Große; author: Michael Große):

[wikidata/query-builder@master] Apply `npm audit fix`

https://gerrit.wikimedia.org/r/902421

Michael moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Mar 24 2023, 7:36 AM
gerritbot added a comment.Mar 24 2023, 8:57 AM

Change 902421 merged by jenkins-bot:

[wikidata/query-builder@master] Apply `npm audit fix`

https://gerrit.wikimedia.org/r/902421

Lucas_Werkmeister_WMDE subscribed.Mar 24 2023, 3:49 PM

If there are open Addbot patches

The only remaining one is for netlify-cli, which is blocked IIUC. Is there anything else left to do / review here?

Michael closed this task as Resolved.Mar 24 2023, 3:53 PM
Michael moved this task from Peer Review to Our work done on the Wikidata Dev Team (Sprint-∞) board.

Ah no, this is done, I think. I just was distracted from closing it (and wondering why the Patch-For-Review tag hasn't been removed yet).

Now it is closed. Thank you for all the reviews!

Lucas_Werkmeister_WMDE mentioned this in T333844: RTL layout broken in latest query builder code.Apr 3 2023, 3:04 PM
karapayneWMDE moved this task from Our work done to 2023 completed tasks on the Wikidata Dev Team (Sprint-∞) board.May 12 2023, 8:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL