Automatic topic subscriptions are not enabled for new users on their "non home wiki"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Mar 20 2023, 5:23 PM

Description

To avoid turning on this feature for "old" users, we set the default to be disabled/false/off.

We then have a hook that runs when an account is created to turn the preference on.

This hook also runs when an existing user logs into a 2nd wiki (or 3rd, 4th...).

We don't check at that point if the user is a new user who was defaulted into the feature, or an old user who we left the feature off for, instead we assume they are an old user and don't turn on the feature.

We copied this code from Echo, which also has a set of preference for new users, so this bug will be present there too.

QA

Create an account an en.wiki
Observe automatic topic subscriptions are enabled
Go to fr.wiki and look at your prefs
Observe automatic topic subscriptions are disabled
Expected: enabled

Details

	Subject	Repo	Branch	Lines +/-
	Enable automatic topic subscriptions for autocreate accounts	mediawiki/extensions/DiscussionTools	master	+9 -11

Customize query in gerrit

Related Objects

Mentioned In: T317375: [Config change] Deploy New Topic Tool as opt-out preference at fi.wiki (desktop)

Event Timeline

Esanders created this task.Mar 20 2023, 5:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2023, 5:23 PM

• ppelberg added a project: Editing-team (Kanban Board).Mar 20 2023, 7:38 PM

• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

matmarex mentioned this in T317375: [Config change] Deploy New Topic Tool as opt-out preference at fi.wiki (desktop).Apr 13 2023, 5:41 PM

Esanders updated the task description. (Show Details)Jun 19 2023, 3:03 PM

Change 943554 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Enable automatic topic subscriptions for autocreate accounts

https://gerrit.wikimedia.org/r/943554

gerritbot added a project: Patch-For-Review.Jul 31 2023, 12:40 PM

The above patch will enable topic subscriptions for "autocreate" accounts (accounts created when you login to a new wiki with an existing SUL account).

It is expected that when you login to a new wiki with an existing SUL account, that all of your preferences will be set to new defaults (excluding GlobalPreferences). I don't think this is any different. As an experienced user I would not be surprised to login to a new wiki and see completely different preferences and features enabled.

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Jul 31 2023, 12:45 PM

• ppelberg awarded a token.Aug 1 2023, 4:19 PM

DLynch assigned this task to Esanders.Aug 1 2023, 4:28 PM

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.

DLynch added a project: Editing QA.

Change 943554 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Enable automatic topic subscriptions for autocreate accounts

https://gerrit.wikimedia.org/r/943554

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 1 2023, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 1 2023, 5:10 PM

Tested with enwiki and dewiki

In prod since change isn't yet in prod

Screenshot 2023-08-09 at 01.38.29.png (388×1 px, 116 KB)

Result when tested in https://de.wikipedia.beta.wmflabs.org/

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Aug 9 2023, 12:42 AM

• ppelberg closed this task as Resolved.Aug 17 2023, 10:39 PM

	F37347085: Screenshot 2023-08-09 at 01.40.35.png
	Aug 9 2023, 12:42 AM

	F37347041: Screenshot 2023-08-09 at 01.38.29.png
	Aug 9 2023, 12:42 AM

Automatic topic subscriptions are not enabled for new users on their "non home wiki"Closed, ResolvedPublicActions

Description

QA

Details

Related Objects

Event Timeline

Automatic topic subscriptions are not enabled for new users on their "non home wiki"
Closed, ResolvedPublic
Actions