Maniphest T332634

[Java] Add more test scenarios for validating config
Closed, DeclinedPublic8 Estimated Story Points
Actions

Assigned To

None

Authored By

	cjming
	Mar 20 2023, 8:18 PM

Tags

Referenced Files

None

Subscribers

JVanderhoop-WMF

Description

With basic WireMock infrastructure in place, add more tests for error conditions during stream config fetching to improve reliability of code.

Get config returns HTTP/500, with a valid config (the code should treat that as an error and not load it)
Get config returns an invalid config
Get config times out (StreamConfigFetcher should fail after no more than a reasonable amount of time - 5 second?)
Get config is an invalid URL, not connecting at all
The above 4 (or a subset), but loading a valid config first, and having an error on the second config reload (the MetricsClient should keep using the valid config and ignore the new one)
EventGate returns HTTP/500 (events should be re-enqueued and sent when EventGate recovers)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[WIP] Get config returns HTTP/500, with a valid config	mediawiki/libs/metrics-platform	master	+34 -0

Customize query in gerrit

Related Objects

Mentioned Here: T401023: [XL] xLab Client Library: Convert to Kotlin and bring into app repo.

Event Timeline

cjming created this task.Mar 20 2023, 8:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2023, 8:18 PM

cjming moved this task from Backlog to To be discussed on the Metrics Platform board.Mar 21 2023, 1:23 AM

Change 902843 had a related patch set uploaded (by EJoseph; author: EJoseph):

[mediawiki/libs/metrics-platform@master] [WIP] Get config returns HTTP/500, with a valid config

https://gerrit.wikimedia.org/r/902843

gerritbot added a project: Patch-For-Review.Mar 25 2023, 2:33 PM

phuedx moved this task from To be discussed to Metrics Platform Kanban on the Metrics Platform board.Mar 27 2023, 3:28 PM

phuedx edited projects, added Metrics Platform (Metrics Platform Kanban); removed Metrics Platform.

phuedx triaged this task as Low priority.Aug 14 2023, 1:30 PM

phuedx moved this task from Ready to Blocked/Paused on the Metrics Platform (Metrics Platform Kanban) board.

phuedx moved this task from Metrics Platform Kanban to To be prioritised on the Metrics Platform board.Aug 15 2023, 12:20 PM

phuedx edited projects, added Metrics Platform; removed Metrics Platform (Metrics Platform Kanban).

phuedx moved this task from To be prioritised to Client improvements on the Metrics Platform board.Jan 16 2024, 11:47 AM

phuedx added a project: Technical-Debt.

cjming set the point value for this task to 8.Jan 16 2024, 6:39 PM

• VirginiaPoundstone edited projects, added Test Kitchen; removed Metrics Platform.Jan 17 2025, 2:11 PM

Declining as we are moving to Kotlin. T401023: [XL] xLab Client Library: Convert to Kotlin and bring into app repo.