Page MenuHomePhabricator

Clicking logout results in an error
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
An error page is presented, with the message "A website error has occurred. The website administrator has been notified of the issue. Sorry for the temporary inconvenience."

What should have happened instead?:
You are logged out, and the page refreshes

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
error.log shows:

{"@timestamp":"2023-03-20T20:21:17.431386+00:00","@version":1,"host":"copypatrol-76799d54f6-m5xzp","message":"ErrorException: session_regenerate_id(): Cannot regenerate session id - session is not active in /data/project/copypatrol/vendor/wikimedia/slimapp/src/Auth/AuthManager.php:147\nStack trace:\n#0 [internal function]: Slim\\Slim::handleErrors()\n#1 /data/project/copypatrol/vendor/wikimedia/slimapp/src/Auth/AuthManager.php(147): session_regenerate_id()\n#2 /data/project/copypatrol/src/App.php(400): Wikimedia\\Slimapp\\Auth\\AuthManager->logout()\n#3 [internal function]: Plagiabot\\Web\\App->Plagiabot\\Web\\{closure}()\n#4 /data/project/copypatrol/vendor/slim/slim/Slim/Route.php(468): call_user_func_array()\n#5 /data/project/copypatrol/vendor/slim/slim/Slim/Slim.php(1355): Slim\\Route->dispatch()\n#6 /data/project/copypatrol/vendor/slim/slim/Slim/Middleware/Flash.php(85): Slim\\Slim->call()\n#7 /data/project/copypatrol/vendor/slim/slim/Slim/Middleware/MethodOverride.php(92): Slim\\Middleware\\Flash->call()\n#8 /data/project/copypatrol/vendor/wikimedia/slimapp/src/HeaderMiddleware.php(69): Slim\\Middleware\\MethodOverride->call()\n#9 /data/project/copypatrol/vendor/wikimedia/slimapp/src/CsrfMiddleware.php(71): Wikimedia\\Slimapp\\HeaderMiddleware->call()\n#10 /data/project/copypatrol/vendor/slim/slim/Slim/Slim.php(1300): Wikimedia\\Slimapp\\CsrfMiddleware->call()\n#11 /data/project/copypatrol/vendor/wikimedia/slimapp/src/AbstractApp.php(184): Slim\\Slim->run()\n#12 /data/project/copypatrol/public_html/index.php(45): Wikimedia\\Slimapp\\AbstractApp->run()\n#13 {main}","type":"app","channel":"app","level":"ERROR","url":"/logout?","ip":"192.168.190.209","http_method":"GET","server":"copypatrol.toolforge.org","referrer":"https://copypatrol.toolforge.org/en/","uid":"a65bfde","process_id":1316}

Event Timeline

Restricted Application added subscribers: Cyberpower678, Aklapper. · View Herald Transcript

Change 901304 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[wikimedia/slimapp@master] AuthManager: don't use session_destroy()

https://gerrit.wikimedia.org/r/901304

Change 901304 merged by jenkins-bot:

[wikimedia/slimapp@master] AuthManager: don't use session_destroy()

https://gerrit.wikimedia.org/r/901304

Both https://copypatrol.toolforge.org and staging have been updated. Logging out no longer seems to throw an error. Resolving as this is very tiny and I don't think requires QA resources.