Page MenuHomePhabricator

Refresh token generation throws 403 error
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Obtain refresh_token using /v1/login API
  • Trigger /v1/token-refresh API more than 5 times

What happens?:
See that although your refresh token is still valid you are getting 403 response.

What should have happened instead?:
You should get a valid access token.

Notes
This is happening due to limitations on max amount of access tokens per refresh token we have put in place. We need to consider either changing the logic or updating the max amount of access tokens per refresh token. Also we should add an expiration date for the cache entries that are counting access tokens.

Also need to consider whether we should update the v1 API as well with this fix.

Event Timeline

Felixejofre set the point value for this task to 5.Mar 24 2023, 3:55 PM
Alexander.lauie changed the task status from Open to In Progress.Mar 30 2023, 1:18 PM