After the new nearby articles mode (T304076) of Kartographer is launched and T90645 has been completed, we should work on enabling the most important Wikivoyage communities to switch over to this new feature, with the eventual goal of being able to deprecate and remove the custom data layer for nearby Wikivoyage articles from the Kartographer source code.
The wgKartographerWikivoyageMode adds several additional features specific to Wikivoyage. One of these features is that if a nearbyArticlesCfg is set in MediaWiki:Kartographer.js, this source will be used to add an additional layer to the layers control to load nearby articles from an external source. Most of these POIs will now be available via the new nearby articles mode (although likely not all/not the same etc).
The reason to switch away from the old method is multiple but includes:
- Performance: T190069: Low performance for the display of map push-pin markers
- Security: T244691: WikiVoyage nearby articles map layer loads a JS file from toolforge and T194088: Wikivoyage should provide non external Nearby articles
- Stale/outdated content: T203313: Permanent update of Wikivoyage nearby-articles data files necessary
For this to be accomplished, the following steps should done
- The community is satisfied with the new solution/will not object too strongly if we remove the old functionality
- Ensure the new config is enabled for each of these wikis
- Remove nearbyArticlesCfg and setup from each wiki's configuration ( https://global-search.toolforge.org/?q=wv%5C.NearbyArticles%5C.setConfig®ex=1&namespaces=8 )
- Ensure no other parts of the WV nearby code are used in scripts or gadgets
- Remove the logic from the Kartographer extension / leave stubs with deprecation warnings for parts still in use
- Ensure that the old PruneCluster library is not used in scripts or gadgets ( https://global-search.toolforge.org/?q=ext%5C.kartographer%5C.lib%5C.prunecluster®ex=1 )
- Remove PruneCluster library from the Kartographer extension
Queries used to look for usages:
- https://codesearch.wmcloud.org/search/?q=ext%5C.kartographer%5C.wv
- https://global-search.toolforge.org/?q=ext%5C.kartographer%5C.wv®ex=1
- https://codesearch.wmcloud.org/search/?q=%5C.nearby%5C(%5C)
- https://global-search.toolforge.org/?q=%5C.nearby%5C(%5C)®ex=1
- https://codesearch.wmcloud.org/search/?q=NearbyArticles
- https://global-search.toolforge.org/?q=NearbyArticles
- https://codesearch.wmcloud.org/search/?q=ControlNearby
- https://global-search.toolforge.org/?q=ControlNearby