Page MenuHomePhabricator

[maintain-dbusers] when filtering by a tool we use inconsistent filters
Closed, InvalidPublicBUG REPORT

Description

When using --only-users <tool>, and using a tool user there's a first check that matches the template tools.<tool> and a second one that matches <tool>, so you can't really filter by those properly.

Example of log where the tool is filtered out:

root@cloudcontrol1005:~# ./maintain-dbusers maintain --only-user wdqsbe --account-type tool --debug
...
INFO [root.create_accounts:931]
                                create_accounts: skipping user tools.wdqsbe with account_type tool.
                                for test purposes, this user wasn't included in the list of target
                                users

Event Timeline

dcaro created this task.

Change 902817 had a related patch set uploaded (by David Caro; author: David Caro):

[operations/puppet@production] maintain-dbusers: only-users match tool users with or without prefix

https://gerrit.wikimedia.org/r/902817

Not needed, the solution is to use 'tools.*' prefix when selecting tool users

Change 902817 abandoned by David Caro:

[operations/puppet@production] maintain-dbusers: only-users match tool users with or without prefix

Reason:

This is not needed \o/

https://gerrit.wikimedia.org/r/902817