Page MenuHomePhabricator

[maintain-dbusers] When creating accounts, the script bails out processing other accounts if one of them fails in an unexpected way
Closed, ResolvedPublicBUG REPORT


This happens in the create_account method, where the tool account test-abogott5 fails to get created, and any account that happens to be listed after it does not get created either.

Event Timeline

dcaro created this task.

Fail fast has basically always been the behavior of maintain-dbusers. The historic fix would be one of delete the broken account (test-abogott5) or correct whatever is causing the account's failure.

The reason for fail fast is basically so that the errors become a blocker that must be fixed instead of being a growing number of single failures that are not monitored or fixed. If we had some better monitoring to notice when one thing is failing every exec loop without blocking the loop it would be completely reasonable to fix things so that a single failure does not halt the entire queue.

The problem is that it does not fail the script, or the service, it just skips the rest of accounts for the toolsdb database. Maybe failing the run might be better there (or as you say, more granular monitoring might be best)