Page MenuHomePhabricator
Create Task
Maniphest T332809

Please disable Vector js/css sharing on pl.wikipedia
Closed, ResolvedPublic
Actions

Description

I already informed people in January 2023 that this would happen. Also added a fresh notice this will happen.
https://pl.wikipedia.org/w/index.php?oldid=69813018#Migracja_z_vector.css_i_vector.js

<del>You can go ahead and disable VectorShareUserScripts for plwiki. Can you do it Thursday, 19:00 UTC? (so in ~24h). Or Monday same time?</del>

Just to be clear I expect this outcome:

  • User Alice can load styles/scripts on the Vector skin using User:Alice/vector.js and User:Alice/vector.css
  • User Bob can load styles/scripts on the Vector 2022 skin using User:Bob/vector-2022.js and User:Bob/vector-2022.css
  • Vector 2022 skin does not load MediaWiki:Vector.css but instead only MediaWiki:Vector-2022.css

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Disable Vector js/css sharing on pl.wikipediaoperations/mediawiki-configmaster+7 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nux created this task.Mar 22 2023, 6:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2023, 6:53 PM
Nux updated the task description. (Show Details)Mar 29 2023, 1:00 AM
Nux mentioned this in T331679: Disable automatic sharing of site/user scripts between Vector and Vector 2022 skins.Mar 29 2023, 9:10 PM

About 15 UTC would be fine for me (just about my dinner time)...
https://www.timeanddate.com/worldclock/fixedtime.html?iso=20230330T17&p1=262&ah=5

But if that would be hard, then I guess it can be few hours earlier, I'm working remote anyway and can get on chat with people if they need help.

gerritbot added a comment.Mar 29 2023, 9:17 PM

Change 904284 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Disable Vector js/css sharing on pl.wikipedia

https://gerrit.wikimedia.org/r/904284

gerritbot added a project: Patch-For-Review.Mar 29 2023, 9:17 PM
Jdlrobson added a comment.Mar 29 2023, 9:18 PM

I've prepared the patch. Anyone should feel free to backport it, otherwise I can do that sometime within the next 2 weeks.

gerritbot added a comment.Apr 3 2023, 8:07 PM

Change 904284 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable Vector js/css sharing on pl.wikipedia

https://gerrit.wikimedia.org/r/904284

Stashbot added a comment.Apr 3 2023, 8:07 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-03T20:07:35Z] <kindrobot@deploy2002> Started scap: Backport for [[gerrit:905264|[refactor] split out Minerva configuration from main config]], [[gerrit:904284|Disable Vector js/css sharing on pl.wikipedia (T332809)]]

Stashbot added a comment.Apr 3 2023, 8:08 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-03T20:08:53Z] <kindrobot@deploy2002> kindrobot and jdlrobson: Backport for [[gerrit:905264|[refactor] split out Minerva configuration from main config]], [[gerrit:904284|Disable Vector js/css sharing on pl.wikipedia (T332809)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Maintenance_bot removed a project: Patch-For-Review.Apr 3 2023, 8:10 PM
Stashbot added a comment.Apr 3 2023, 8:19 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-03T20:19:40Z] <kindrobot@deploy2002> Finished scap: Backport for [[gerrit:905264|[refactor] split out Minerva configuration from main config]], [[gerrit:904284|Disable Vector js/css sharing on pl.wikipedia (T332809)]] (duration: 12m 05s)

Jdlrobson closed this task as Resolved.Apr 3 2023, 8:54 PM
Jdlrobson claimed this task.

This is now live. @Nux I'm not seeing any new errors in our production error logs and everything looks as it was. Please reopen if you discover a follow up is needed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits