This code:
.foo {
color: blue;
@supports ( mask-image: none) {
mask-image: url( 'my-image-url' );
}
}should parse to:
.foo {
color: blue;
}
@supports ( mask-image: none) {
.foo {
mask-image: url( 'my-image-url' );
}
}This works when compiling with less.js. However, with Less.php, the @supports ruleset does not include any selector, so you get this:
.foo {
color: blue;
}
@supports ( mask-image: none) {
mask-image: url( 'my-image-url' );
}| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T330468 [EPIC] Enable use of CSS-only Codex components in MediaWiki | |||
| Resolved | BUG REPORT | Etonkovidova | T330691 Table of mentees on the Mentor dashboard is not visible on Timeless | ||
| Resolved | Catrope | T328602 Enable use of Codex Less mixins inside of MediaWiki | |||
| Open | None | T288498 Update less.php port to support Less.js 3.13 behaviours | |||
| Resolved | • Hokwelum | T365481 Update less.php port to complete support Less.js 2.5.3 behaviours | |||
| Resolved | AnneT | T332923 `@supports` ruleset doesn't include the selector |
Using http://ecomfe.github.io/est/fiddle/#version=2.4.0&autoprefix=false&est=false&autorun=false, it seems this was upstream less.js behaviour in 2.4.0 and changed to the current behaviour in 2.5.0, though seemingly without coverage by upstream's test specification, hence it was likely missed by less.php maintainers until now (noting that Wikimedia took over less.php maintenance in 2019).
Aha, thanks!
@Catrope See the diff between these two versions; looks like the commits on Feb 24, 2015 probably contain the changes we need to port.
Thanks for finding this! I think the responsible commit might be this one, which appears to add tests in directives-bubbling.less. It looks like the commit that follows it may be related too. I found some of these pieces while trying to fix this, but this should give a better picture of the changes we need to port.
Thanks for picking this up, please let us know if we can provide any help or guidance.
Change 905994 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):
[mediawiki/libs/less.php@master] Directive: Bubble directives up to the global scope
Change 905994 merged by jenkins-bot:
[mediawiki/libs/less.php@master] Directive: Bubble directives up to the global scope
Change 907545 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/libs/less.php@master] Tag v4.1.0
Change 907564 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/core@master] ResourceLoader: Update wikimedia/less.php from 4.0.0 to 4.1.0
Change 907564 merged by jenkins-bot:
[mediawiki/core@master] ResourceLoader: Update wikimedia/less.php from 4.0.0 to 4.1.0
Change 907980 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):
[mediawiki/extensions/VueTest@master] Reinstate CSS-only button-with-icon examples
Change 907980 merged by jenkins-bot:
[mediawiki/extensions/VueTest@master] Reinstate CSS-only button-with-icon examples