Page MenuHomePhabricator
Create Task
Maniphest T332995

Add integration/quibble to codesearch
Closed, ResolvedPublic
Actions

Description

T332930: Make AutoLoader::$psr4Namespaces private caused a breakage. Codesearch didn't see any usages of psr4Namespaces, because seemingly the quibble repo isn't in codesearch.

As it is used for some CI glue, including PHP code dependant on MW, it seems a good candidate to be indexed so that hopefully issues like this don't show up in future

Details

SubjectRepoBranchLines +/-
Add integration/quibble repolabs/codesearchmaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Mar 24 2023, 1:55 PM
gerritbot added a comment.Mar 24 2023, 6:59 PM

Change 902767 had a related patch set uploaded (by Jforrester; author: Jforrester):

[labs/codesearch@master] Add integration/quibble repo

https://gerrit.wikimedia.org/r/902767

gerritbot added a project: Patch-For-Review.Mar 24 2023, 6:59 PM
Ladsgroup closed this task as Resolved.Mar 24 2023, 10:29 PM
Ladsgroup claimed this task.
Ladsgroup subscribed.

It should be there in a couple of hours.

Ladsgroup reassigned this task from Ladsgroup to Jdforrester-WMF.Mar 24 2023, 10:30 PM
gerritbot added a comment.Mar 24 2023, 10:30 PM

Change 902767 merged by jenkins-bot:

[labs/codesearch@master] Add integration/quibble repo

https://gerrit.wikimedia.org/r/902767

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2023, 11:10 PM
hashar reopened this task as Open.Mar 26 2023, 8:02 AM
hashar subscribed.

Reopening since the config change hasn't been taken in account, Quibble does not show up in the Select repos search nor do any of its code is found. Maybe the configuration hasn't been deployed / reloaded?

kostajh closed this task as Resolved.Mar 27 2023, 8:31 AM
kostajh subscribed.
In T332995#8726983, @hashar wrote:

Reopening since the config change hasn't been taken in account, Quibble does not show up in the Select repos search nor do any of its code is found. Maybe the configuration hasn't been deployed / reloaded?

Seems to be there now, see e.g. https://codesearch.wmcloud.org/search/?q=earlywarning%3A&files=&excludeFiles=&repos=#Quibble%20continuous%20integration%20runner

image.png (1×2 px, 313 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL