Page MenuHomePhabricator

Fix broken cache for http://bits.wikimedia.org/w/extensions-1.17/FlaggedRevs/client/flaggedrevs.js?87&301-3
Closed, ResolvedPublic

Description

Author: saibotrash

Description:
I (and other users in dewp http://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia#Diff_und_Artikelansicht ) get the JS error "Uncaught exception: ReferenceError: Undefined variable: FlaggedRevs" (Opera, not logged in) and similar errors in Firefox (logged in) when viewing(!) an random article http://de.wikipedia.org/wiki/Spezial:Zuf%C3%A4llige_Seite This at least prevents the article text to be loaded in diff view (which is urgently needed for re-sighting) - example: http://de.wikipedia.org/w/index.php?title=Hinschenfelde&diff=80985219&oldid=80975076 . It started not to work approx. at 17:01, 30. Sep. 2011 (UTC)

BTW: Don't the tests or pre-deployment tests include a simple article view and look in the JS error console? ;)


Version: unspecified
Severity: critical
URL: http://de.wikipedia.org/w/index.php?title=Hinschenfelde&diff=80985219&oldid=80975076

Details

Reference
bz31301

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:51 PM
bzimport set Reference to bz31301.
bzimport added a subscriber: Unknown Object (MLST).

The error you are referring to (Uncaught ReferenceError: FlaggedRevs is not defined) is not relevant to this problem. Looking further into my error console I see a bigger fish just above that one:

Failed to load resource: the server responded with a status of 404 (Not Found)
http://bits.wikimedia.org/w/extensions-1.17/FlaggedRevs/client/flaggedrevs.js?87&301-3

There is an issue with Wikimedia's -1-17/1-18 set up.

This was tested pre-deployment and worked fine however that was on 1.18.

AFAIK nothing FlaggedRevs was deployed on dewiki and it is still running MediaWiki 1.17. I'm not sure why this would break.

Actually, in 1.18, this fragile (due to load order) mix of inline and non-inline JS will be gone.

Seems to only affect european users, or otherwise a selection of users.

Created attachment 9138
http headers and html content of error

Attached:

Screen_Shot_2011-10-02_at_2.08.16_AM.png (988×1 px, 308 KB)

Note that it's showing a Wikimedia-wiki style error, which are not enabled on bits today

Created attachment 9139
http headers and html content of working url (different query string)

Attached:

Screen_Shot_2011-10-02_at_2.14.54_AM.png (988×1 px, 265 KB)

Created attachment 9140
http headers and html content of working url (different query string) - cache hit

Attached:

Screen_Shot_2011-10-02_at_2.19.22_AM.png (988×1 px, 276 KB)

Robla suggest not to nuke the cache of this one just yet to allow investigation to cause.

I suggest we bump wgStyleVersion instead so that atleast de.wp is able to review revisions again!

(In reply to comment #9)

Robla suggest not to nuke the cache of this one just yet to allow investigation
to cause.

I suggest we bump wgStyleVersion instead so that atleast de.wp is able to
review revisions again!

That actually works for you?

I'll bump the version per comment #2.