Page MenuHomePhabricator

Duplication of "confirmed" user group in special:AbuseFilter permission error text
Closed, DuplicatePublicBUG REPORT

Assigned To
None
Authored By
Andriy.v
Mar 24 2023, 8:32 PM
Referenced Files
F36926212: immagine.png
Mar 24 2023, 8:32 PM
F36926207: immagine.png
Mar 24 2023, 8:32 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:
In the list of user rights, which can access the page, there is a repetition of "confirmed" user group.

What should have happened instead?:
There have to be no duplication of user groups in the list.

Other information (browser name/version, screenshots, etc.):

immagine.png (1,006×187 px, 31 KB)

immagine.png (990×200 px, 32 KB)

Event Timeline

Daimona subscribed.

This is not AbuseFilter-specific. The list of groups is obtained via GroupPermissionLookup::getGroupsWithPermission, which builds a list of all groups by merging $this->groupPermissions and $this->groupInheritance. This list can have duplicates, but they're not removed. In fact, the value of $this->groupInheritance is controlled by $wgGroupInheritsPermissions, whose value in prod is:

'wgGroupInheritsPermissions' => [
	'default' => [
		// Confirmed can do anything autoconfirmed can.
		'confirmed' => 'autoconfirmed',
	],
],

I think this implies that any user right that is assigned to autoconfirmed users would exhibit the same behaviour of duplicating the confirmed group in error messages.