Page MenuHomePhabricator

PageTriage adding mobile link without icon
Open, Needs TriagePublicBUG REPORT

Description

Visiting https://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein as a logged in user with the advanced mode enabled (https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileOptions) I see a menu item with no icon

Screenshot 2023-03-24 at 1.56.17 PM.png (930×2 px, 265 KB)

Developer notes

An icon rule should be added for the mw-ui-icon-portletlink-p-pagetriage-enqueue class

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Jdlrobson is this something the web team will do? Is there an icon you suggest that we use?

The web team is focused primarily on maintaining the platform, not how it's used so not likely something we'd pick up. Presumably this only shows to page triage-rs who are logged in and opted into the advanced model so it does not seem like a high priority bug, but it would be nice to fix.

In terms of fix, I would suggest either removing the menu item in mobile, or finding or provisioning a new icon [1] to style the provided class using ResourceLoaderImageModule.

[1] https://doc.wikimedia.org/oojs-ui/master/demos/?page=icons&theme=wikimediaui&direction=ltr&platform=desktop

It seems to me that articleCheck might be a good candidate icon. Codesearch implies that it's used in FlaggedRevisions, Echo (relating to a reviewed page), and GrowthExperiments (signifying copyediting).

image.png (60×54 px, 3 KB)

It seems to me that articleCheck might be a good candidate icon. Codesearch implies that it's used in FlaggedRevisions, Echo (relating to a reviewed page), and GrowthExperiments (signifying copyediting).

image.png (60×54 px, 3 KB)

Do you have any thoughts on this @Jdlrobson? We're considering this as a small task we could fit in to our PageTriage project, just want to confirm whether this seems a suitable choice.

Sounds fine. I am not sure how valuable this is in the grand scheme of things: are people using page triage on Minerva skin?

Sounds fine. I am not sure how valuable this is in the grand scheme of things: are people using page triage on Minerva skin?

Folks aren't using PageTriage on mobile but it seems possible that they would use this link (flagging that a page needs review). Anyway, definitely a low priority task but also seems like a quick one.